Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charts - more examples #10845

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Charts - more examples #10845

merged 3 commits into from
Sep 5, 2024

Conversation

dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Aug 8, 2024 •
edited
Loading

  • Created a gnatt-like example, demonstrating an alert timeline using horizontal bar charts
  • Updated a pie chart example to demonstrate how to apply custom styles
  • Also fixed an issue with undesired space between tick labels and the bottom positioned legend

Closes #10844

Screenshot 2024-08-08 at 11 23 53 AM

Screenshot 2024-08-08 at 11 24 10 AM

@patternfly-build
Copy link
Contributor

patternfly-build commented Aug 8, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10845.surge.sh

A11y report: https://patternfly-react-pr-10845-a11y.surge.sh

@dlabrecq dlabrecq changed the title Charts - timeline example for bar charts Charts - alerts timeline example for bar charts Aug 8, 2024
@dlabrecq dlabrecq requested a review from nicolethoen August 8, 2024 05:18
@dlabrecq dlabrecq force-pushed the gnatt branch 2 times, most recently from a609b40 to 6c27769 Compare August 8, 2024 15:22
@dlabrecq dlabrecq changed the title Charts - alerts timeline example for bar charts Charts - adding more examples Aug 8, 2024
@dlabrecq dlabrecq changed the title Charts - adding more examples Charts - examples Aug 8, 2024
@dlabrecq dlabrecq changed the title Charts - examples Charts - more examples Aug 8, 2024
@dlabrecq dlabrecq force-pushed the gnatt branch 2 times, most recently from 740f0ef to ad8f4a9 Compare August 9, 2024 20:23
gitdallas
gitdallas approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now :)

@tlabaj
Copy link
Contributor

tlabaj commented Aug 27, 2024

Can you target v6 branch for these cahnges?

@tlabaj tlabaj merged commit cf30249 into patternfly:v5 Sep 5, 2024
13 checks passed
@dlabrecq dlabrecq deleted the gnatt branch September 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolethoen nicolethoen nicolethoen approved these changes

@dlabaj dlabaj dlabaj approved these changes

@gitdallas gitdallas gitdallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Charts - alerts timeline example
6 participants
@dlabrecq @patternfly-build @tlabaj @gitdallas @dlabaj @nicolethoen