fix(charts): undesired space between axis label and bottom positioned…

… legend
patternfly · Aug 8, 2024 · 6c27769 · 6c27769
1 parent 78282d1
commit 6c27769
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/react-charts/src/components/Chart/Chart.tsx b/packages/react-charts/src/components/Chart/Chart.tsx
@@ -571,7 +571,7 @@ export const Chart: React.FunctionComponent<ChartProps> = ({
 
     // Adjust for axis label
     React.Children.toArray(children).map((child: any) => {
-      if (child.type.role === 'axis' && child.props.label && !child.props.dependentAxis) {
+      if (child.type.role === 'axis' && child.props.label && child.props.fixAxisLabelHeight) {
         xAxisLabelHeight = getLabelTextSize({ text: child.props.label, theme }).height + 10;
         legendTitleHeight = 0;
       }

diff --git a/packages/react-charts/src/components/ChartAxis/ChartAxis.tsx b/packages/react-charts/src/components/ChartAxis/ChartAxis.tsx
@@ -157,6 +157,10 @@ export interface ChartAxisProps extends VictoryAxisProps {
    * @propType object[]
    */
   externalEventMutations?: EventCallbackInterface<string | string[], StringOrNumberOrList>[];
+  /**
+   * When true, this prop adjusts the height between the axis label and bottom positioned legend
+   */
+  fixAxisLabelHeight?: boolean;
   /**
    * When true, this prop reduces the number of tick labels to fit the length of the axis.
    * Labels are removed at approximately even intervals from the original array of labels.