Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TypeaheadSelect) Add creation options to TypeaheadSelect #10802

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

jeff-phillips-18
Copy link
Member

What:
Closes #10798

Description:
Adds options to allow creation of new items from the @patternfly/react-templates TypeaheadSelect component.

@patternfly-build
Copy link
Contributor

patternfly-build commented Jul 25, 2024

@jeff-phillips-18 jeff-phillips-18 force-pushed the typeahead-create branch 2 times, most recently from e3de113 to d83df4f Compare July 26, 2024 17:46
Copy link
Contributor

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, creation functionality works as expected and tests fixed

@tlabaj tlabaj merged commit 4105430 into patternfly:main Jul 29, 2024
13 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the typeahead-create branch July 29, 2024 15:48
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-docs@6.4.0-prerelease.50
  • @patternfly/react-templates@1.1.0-prerelease.37

Thanks for your contribution! 🎉

tlabaj pushed a commit to tlabaj/patternfly-react that referenced this pull request Jul 31, 2024
kmcfaul added a commit that referenced this pull request Aug 8, 2024
* fix(TypeaheadSelect): Add callback on clear selection (#10719)

* fix(CodeEditor) resizeObserver resize loop (#10644)

* fix(CodeEditor) resizeObserver resize loop

* yarn

* add debounce

---------

Co-authored-by: Titani <tlabaj@redhat.com>

* cherry pick fix(SimpleSelect,CheckboxSelect): Handle initial selection(s)

* (Drag and drop): Updated example for multi list to use flex

* docs(Table): add Editable Table example

* fix(DragDrop): fix flexgrow type

* feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates (#10757)

* feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates

* Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx

Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>

---------

Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>

* fix(TypeaheadSelect): Correctly show the newly selected item on selection (#10792)

* feat(TypeaheadSelect) Add creation options to TypeaheadSelect (#10802)

* update MultiTypeaheadSelect to use label instead of chip

* chore(deps): upgrade eslint-plugin-react to the latest (#10739)

* chore(deps): upgrade `eslint-plugin-markdown` to the latest version (#10738)

Signed-off-by: Jon Koops <jonkoops@gmail.com>

* resolve merge conflicts

* feat(eslint-plugin-patternfly-react): update rules for eslint v9 (#10743)

* resolve conflicts for chore(deps): upgrade ESLint to the latest version

* fix yarn lint issue

* fix yarn lint issue

* fix(TypeaheadSelect): Update input value only when appropriate (#10826)

* fix lint errors and demo-app

---------

Signed-off-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: Jeff Phillips <jephilli@redhat.com>
Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com>
Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeaheadSelect - Add creation options to @patternfly/react-templates TypeaheadSelect
5 participants