-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates #10757
feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates #10757
Conversation
Preview: https://patternfly-react-pr-10757.surge.sh A11y report: https://patternfly-react-pr-10757-a11y.surge.sh |
6a8dd11
to
2e41794
Compare
2e41794
to
ccf4280
Compare
const [activeItemId, setActiveItemId] = React.useState<string | null>(null); | ||
const textInputRef = React.useRef<HTMLInputElement>(); | ||
|
||
const NO_RESULTS = 'no results'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a prop so consumers an change this string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. It looks like that is not a display string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then titani's comment LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one behavioral bug, everything else lgtm
packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx
Outdated
Show resolved
Hide resolved
…elect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
Your changes have been released in:
Thanks for your contribution! 🎉 |
…es (patternfly#10757) * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates * Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> --------- Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com>
* fix(TypeaheadSelect): Add callback on clear selection (#10719) * fix(CodeEditor) resizeObserver resize loop (#10644) * fix(CodeEditor) resizeObserver resize loop * yarn * add debounce --------- Co-authored-by: Titani <tlabaj@redhat.com> * cherry pick fix(SimpleSelect,CheckboxSelect): Handle initial selection(s) * (Drag and drop): Updated example for multi list to use flex * docs(Table): add Editable Table example * fix(DragDrop): fix flexgrow type * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates (#10757) * feat(MultiTypeaheadSelect): Add MultiTypeaheadSelect to react-templates * Update packages/react-templates/src/components/Select/MultiTypeaheadSelect.tsx Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> --------- Co-authored-by: Titani Labaj <39532947+tlabaj@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> * fix(TypeaheadSelect): Correctly show the newly selected item on selection (#10792) * feat(TypeaheadSelect) Add creation options to TypeaheadSelect (#10802) * update MultiTypeaheadSelect to use label instead of chip * chore(deps): upgrade eslint-plugin-react to the latest (#10739) * chore(deps): upgrade `eslint-plugin-markdown` to the latest version (#10738) Signed-off-by: Jon Koops <jonkoops@gmail.com> * resolve merge conflicts * feat(eslint-plugin-patternfly-react): update rules for eslint v9 (#10743) * resolve conflicts for chore(deps): upgrade ESLint to the latest version * fix yarn lint issue * fix yarn lint issue * fix(TypeaheadSelect): Update input value only when appropriate (#10826) * fix lint errors and demo-app --------- Signed-off-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: Jeff Phillips <jephilli@redhat.com> Co-authored-by: Dominik Petřík <77832970+Dominik-Petrik@users.noreply.github.com> Co-authored-by: kmcfaul <45077788+kmcfaul@users.noreply.github.com> Co-authored-by: Jon Koops <jonkoops@gmail.com>
What:
Closes #10733
Description:
Adds a
MultiTypeaheadSelect
component to the @patternfly/react-templates package and a demo of the component for the docs apge.