fix: Alias name for req.alias containing a dot fail to intercept (c…

…ypress-io#14621)
pashidlos · Jan 30, 2021 · e35d38f · e35d38f
1 parent 90f31d3
commit e35d38f
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 3 deletions.
diff --git a/packages/driver/cypress/integration/commands/net_stubbing_spec.ts b/packages/driver/cypress/integration/commands/net_stubbing_spec.ts
@@ -2477,6 +2477,23 @@ describe('network stubbing', { retries: 2 }, function () {
 
         cy.wait('@netAlias').its('response.body').should('equal', 'my value')
       })
+
+      // https://github.com/cypress-io/cypress/issues/14444
+      it('can use dot in request alias', () => {
+        cy.intercept('/users', (req) => {
+          req.alias = 'get.url'
+          req.reply('foo')
+        })
+
+        cy.window().then((win) => {
+          const xhr = new win.XMLHttpRequest()
+
+          xhr.open('GET', '/users')
+          xhr.send()
+        })
+
+        cy.wait('@get.url')
+      })
     })
   })
 })
diff --git a/packages/driver/src/cy/commands/waiting.js b/packages/driver/src/cy/commands/waiting.js
@@ -100,11 +100,16 @@ module.exports = (Commands, Cypress, cy, state) => {
       _.keys(cy.state('aliases')).includes(str.slice(1))) {
         specifier = null
       } else {
-        // potentially request, response or index
+        // potentially request, response
         const allParts = _.split(str, '.')
+        const last = _.last(allParts)
 
-        str = _.join(_.dropRight(allParts, 1), '.')
-        specifier = _.last(allParts)
+        if (last === 'request' || last === 'response') {
+          str = _.join(_.dropRight(allParts, 1), '.')
+          specifier = _.last(allParts)
+        } else {
+          specifier = null
+        }
       }
 
       let aliasObj