fix: Alias name for req.alias containing a dot fail to intercept
#14621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
sainthkh
commented
Jan 19, 2021
| @@ -100,11 +100,16 @@ module.exports = (Commands, Cypress, cy, state) => { | |||
| _.keys(cy.state('aliases')).includes(str.slice(1))) { | |||
| specifier = null | |||
| } else { | |||
| // potentially request, response or index | |||
| // potentially request, response | |||
There was a problem hiding this comment.
index part is added at #4248. As far as I researched, there was no test to use a number with cy.wait. It's for cy.get. That's why I removed this.
Maybe I might be wrong.
flotwig
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TR-620
req.aliascontaining a dot fail to intercept #14444User facing changelog
When there was a dot in
req.alias, it failed. This PR fixes this problem.Additional details
req.aliasfailed without reason.requestandresponse.How has the user experience changed?
N/A
Documentation problem.
requestandresponseare reserved. But it is not documented incy.wait,cy.intercept,cy.routedocs.Only documentation I could find was 0.5.10 changelog. I think it should be added to avoid confusion.
PR Tasks
cypress-documentation? => Added a section above to get feedback.