Variadic record elements #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
approved these changes
Jan 26, 2021
| @@ -3264,6 +3273,7 @@ class TestDomain private constructor() { | |||
| val elements = listOfNotNull( | |||
| ionSymbol("human"), | |||
| firstName?.let { ionSexpOf(ionSymbol("first_name"), it.toIonElement()) }, | |||
| if(middleNames.any()) { ionSexpOf(ionSymbol("middle_names"), *middleNames.map { it.toIonElement() }.toTypedArray()) } else { null }, | |||
There was a problem hiding this comment.
nit: could add a space after if for consistency
Comment on lines
+81
to
+82
| tc.messageMustContainStrings.forEach { | ||
| assertTrue(ex.message!!.contains(it), "exception message must contain '$it'") |
There was a problem hiding this comment.
nit: Hmm is there a better way to check the exception messages? Perhaps something similar to what is done in TypeDomainParserErrorsTest.kt?
There was a problem hiding this comment.
I'd agree that would be better but that part of the code isn't currently factored to do that and doing so should be a separate effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #44.
This builds on #60, which should be merged first.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.