Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute Gradle task generateTestDomains before pig-tests sub-project is compiled #17

Closed
dlurton opened this issue Jul 9, 2020 · 0 comments

Comments

@dlurton
Copy link
Member

dlurton commented Jul 9, 2020

To reproduce this, delete pig-tests/src/org/partiql/pig/tests/generated/sample-universe.kt and then execute ./gradlew build. The resulting build failure clearly indicates that the file is not being regenerated before the pig-tests sub-project is being compiled. The intent was to make generateTestDomains execute before pig-tests is compiled.

Because this file is checked into the repository, this is little more than a minor annoyance right now but might lead to confusing behaviour for developers who are unaware of this.

dlurton added a commit that referenced this issue Jan 9, 2021
Fixes #17

Also split sample-universe.ion and sample-universe.kt into 3 smaller
files.
dlurton added a commit that referenced this issue Jan 9, 2021
Fixes #17

Also split sample-universe.ion and sample-universe.kt into 3 smaller
files.
dlurton added a commit that referenced this issue Jan 9, 2021
Fixes #17

Also split sample-universe.ion and sample-universe.kt into 3 smaller
files.
@dlurton dlurton closed this as completed Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant