Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to travis dpl v2 #6595

Closed
wants to merge 6 commits into from
Closed

Updating to travis dpl v2 #6595

wants to merge 6 commits into from

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Apr 12, 2020

Testing to see if compatible with the update and if warnings disappear

Note that skip_cleanup has been renamed to cleanup and defaults to cleanup: false which is different from pervious version. In addition, deploy now asks for a strategy which defaults to strategy: git for GitHub pages. The other option is strategy: api which looks like it's for all others that are not GitHub pages.

This is just a prep PR and can wait until dpl v2 is out of beta to commit

Testing to see if compatible with the update and if warnings disappear
@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #6595 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6595   +/-   ##
=======================================
  Coverage   93.91%   93.92%           
=======================================
  Files         169      169           
  Lines       11970    11991   +21     
=======================================
+ Hits        11242    11262   +20     
- Misses        728      729    +1     
Impacted Files Coverage Δ
src/Adapters/Auth/httpsRequest.js 95.23% <0.00%> (-4.77%) ⬇️
src/GraphQL/helpers/objectsQueries.js 90.83% <0.00%> (-0.53%) ⬇️
src/GraphQL/ParseGraphQLSchema.js 97.38% <0.00%> (-0.03%) ⬇️
src/RestWrite.js 93.81% <0.00%> (ø)
...rc/Adapters/Storage/Mongo/MongoSchemaCollection.js 97.80% <0.00%> (ø)
.../Adapters/Storage/Postgres/PostgresConfigParser.js 100.00% <0.00%> (ø)
src/middlewares.js 97.31% <0.00%> (+0.02%) ⬆️
src/GraphQL/loaders/parseClassQueries.js 97.95% <0.00%> (+0.04%) ⬆️
src/GraphQL/loaders/parseClassTypes.js 94.23% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1053363...e6bf878. Read the comment docs.

I couldn't find much documentation on this, but using `api` itself says it's unknown.
@dplewis dplewis requested a review from acinader April 23, 2020 14:29
@dplewis
Copy link
Member

dplewis commented Apr 23, 2020

@acinader In our tests for cleanup when deploying to npm we missed the edge: true in the config.

#6457

@acinader
Copy link
Contributor

re-running failed postgres test

@cbaker6
Copy link
Contributor Author

cbaker6 commented Apr 23, 2020

I think I got the configuration correct this time, strategy: git is only used for GitHub pages

If this doesn't work, revert to `git`
@acinader
Copy link
Contributor

why would we want to swtich to edge? why not just wait till its released? I.e. is this curiosity, or do you think we should actually make this switch? I'm inclined to wait as it works currently.

@dplewis
Copy link
Member

dplewis commented Apr 24, 2020

This is just a prep PR and can wait until dpl v2 is out of beta to commit

We can wait until V2 is ready

@cbaker6
Copy link
Contributor Author

cbaker6 commented Apr 24, 2020

This is just a prep PR and can wait until dpl v2 is out of beta to commit

We can wait until V2 is ready

Yup, I initially looked into this to get rid of the warnings in Travis and then I realized those warnings were for preparation for dpl v2. When it’s released it looks like Parse will be ready and the warnings in Travis will be gone.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 3, 2020

Switched to GitHub Actions for deployments

@cbaker6 cbaker6 closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants