Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to get Travis to deploy to npmjs #6457

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Attempt to get Travis to deploy to npmjs #6457

merged 3 commits into from
Mar 2, 2020

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Mar 2, 2020

Use deprecated skip_cleanup: true
as cleanup: false doesn't
appear to be working

@acinader
Use deprecated skip_cleanup
d95cfa6 
as cleanup: false doesn't
appear to be working
@acinader
prepare release
6967ed7
@acinader acinader requested a review from davimacedo March 2, 2020 18:24
@dplewis
Copy link
Member

dplewis commented Mar 2, 2020 •
edited
Loading

I think the previous build was good. The release didn't tag properly.

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

i don't think so. if you expand the deploy step, even though it says it worked, you can see that npm is failing because it doesn't have babel

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

why do you think it didn't tag properly??

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

image

@dplewis
Copy link
Member

dplewis commented Mar 2, 2020

https://travis-ci.org/parse-community/parse-server/jobs/657209717

Screen Shot 2020-03-02 at 12 36 26 PM

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

image

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

i'm optimistic that this change will fix it.

@dplewis
Copy link
Member

dplewis commented Mar 2, 2020

Do you have a link to that job?

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

https://travis-ci.org/parse-community/parse-server/jobs/656523701

@acinader
Copy link
Contributor Author

acinader commented Mar 2, 2020

your link is to the pr merge, not the new tag.

dplewis
dplewis approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@acinader acinader merged commit bde8ab6 into master Mar 2, 2020
@TomWFox TomWFox added the release label Mar 2, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
@acinader
Attempt to get Travis to deploy to npmjs (parse-community#6457)
150a672 
* Use deprecated skip_cleanup
as cleanup: false doesn't
appear to be working

* prepare release

* revert change to branch
@TomWFox TomWFox deleted the travis-busted branch April 3, 2020 16:56
@dplewis dplewis mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplewis dplewis dplewis approved these changes

@davimacedo davimacedo Awaiting requested review from davimacedo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acinader @dplewis @TomWFox