Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1659, replace whitespace with dash. #1677

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Fix #1659, replace whitespace with dash. #1677

merged 4 commits into from
Jan 14, 2024

Conversation

pepoviola
Copy link
Collaborator

fix #1659

@pepoviola pepoviola merged commit 443be9d into main Jan 14, 2024
23 checks passed
@pepoviola pepoviola deleted the fix-1659 branch January 14, 2024 16:45
@l0r1s
Copy link
Contributor

l0r1s commented Jan 15, 2024

@pepoviola just an after thought but maybe we could log to the user that we modified a name if we modified it ? wdyt ?

@pepoviola
Copy link
Collaborator Author

@pepoviola just an after thought but maybe we could log to the user that we modified a name if we modified it ? wdyt ?

Yes, sounds good. I think a warning message will be ok. Can you open an issue to track this?
Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wirednkod wirednkod wirednkod approved these changes

@l0r1s l0r1s Awaiting requested review from l0r1s

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zombienet won't allow whitespaces in collator names
3 participants
@pepoviola @l0r1s @wirednkod