Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zombienet won't allow whitespaces in collator names #1659

Closed
ggwpez opened this issue Jan 9, 2024 · 4 comments · Fixed by #1677
Closed

Zombienet won't allow whitespaces in collator names #1659

ggwpez opened this issue Jan 9, 2024 · 4 comments · Fixed by #1677
Assignees

Comments

@ggwpez
Copy link
Member

ggwpez commented Jan 9, 2024

SE issue mentions that names should be passed in quotes like --name "name" instead of --name name.
Using zombienet v1.89 i did not verify myself, just opening this so we can close the other.

@wirednkod
Copy link
Contributor

wirednkod commented Jan 9, 2024

Thank you @ggwpez
All the configuration options are actually translating into a cmd (e.g. --name someting-something) so having spaces will mean that after 1st word ,the 2nd word will be some other arg.
I am not sure if this should be fixed by mentioning it in the documentation, or adding a trim/replace function to convert the spaced-name to (lets say) dashed-name.
What do you think @pepoviola ?

@wirednkod wirednkod self-assigned this Jan 9, 2024
@pepoviola
Copy link
Collaborator

Hey @wirednkod / @ggwpez, thanks for report this issue. We are using the name of the node in several places and we should check if having a whitespace there doesn't break anything more. I think we should explore if is possible to support naming with whitespace, and if generate more troubles we can move to replace whitespaces with dashes.

Thx!

@wirednkod
Copy link
Contributor

@pepoviola I think the best way to ensure that there is nothing breaking is a simple replacement of spaces -> dashes. It does not really make much sense to me, to have spaces into the name to be honest 🤷🏽

@pepoviola
Copy link
Collaborator

@pepoviola I think the best way to ensure that there is nothing breaking is a simple replacement of spaces -> dashes. It does not really make much sense to me, to have spaces into the name to be honest 🤷🏽

Ok but we should make this transformation clear in the docs since the users should know that the name of the node will be changed replacing spaces with dashes. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants