-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Create trait for NPoS election algorithms #9664
Conversation
… kiz-election-trait
… kiz-election-trait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to fix a few things, but overall correct to me.
Important property to maintain is that this PR should not have ANY logical changes, only abstraction changes.
…bstrate into kiz-election-trait
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
bot merge |
Error: When trying to meet the "Project Owners" approval requirements: this pull request does not belong to a project defined in Process.json. Approval by "Project Owners" is only attempted if other means defined in the criteria for merge are not satisfied first. The following errors might have affected the outcome of this attempt:
|
bot merge |
Error: Approval criteria was not satisfied. The following errors might have affected the outcome of this attempt:
Merge failed. Check out the criteria for merge. |
bot merge |
Trying merge. |
This PR creates a common trait that all NPoS election algorithms can implement. This is particularly helpful when it is desired for the election solving approach to be configurable (e.g an election result mining binary).
polkadot companion: paritytech/polkadot#3752
closes: #9666