Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Allow staking miner to use different election algorithms #3752

Merged
28 commits merged into from
Sep 9, 2021

Conversation

emostov
Copy link
Contributor

@emostov emostov commented Aug 31, 2021

substrate companion: paritytech/substrate#9664

This PR adds the option to use the Phragmen MMS algorithm for the staking miner.

@emostov emostov added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. B0-silent Changes should not be mentioned in any release notes labels Aug 31, 2021
@kianenigma kianenigma changed the title Companion for Create trait for NPoS election algorithms (#9664) Allow staking miner to use different election algorrithms Sep 1, 2021
@kianenigma kianenigma added B1-releasenotes and removed B0-silent Changes should not be mentioned in any release notes B1-releasenotes labels Sep 1, 2021
@kianenigma
Copy link
Contributor

  1. Updating the labels and titles so that this can go into the release note.
  2. Would be interesting to try this PR and run PhragMMS and see if we can come up with any better scores? cc @chevdor

@emostov emostov changed the title Allow staking miner to use different election algorrithms Allow staking miner to use different election algorithms Sep 1, 2021
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
chevdor
chevdor previously requested changes Sep 9, 2021
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

utils/staking-miner/src/main.rs Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 9, 2021

Waiting for commit status.

@ghost ghost merged commit a20a35b into master Sep 9, 2021
@ghost ghost deleted the zeke-npos-solver-trait-companion branch September 9, 2021 20:21
ordian added a commit that referenced this pull request Sep 14, 2021
* master:
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
ordian added a commit that referenced this pull request Sep 15, 2021
* master: (21 commits)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
  Do not expire HRMP open channel requests (#3543)
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  ...
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants