Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

deprecate try-runtime subcommand and direct users to standalone cli #14731

Merged
merged 22 commits into from
Aug 17, 2023

Conversation

liamaharon
Copy link
Contributor

@liamaharon liamaharon commented Aug 8, 2023

Partial #12975

The try-runtime subcommand has been migrated to a standalone CLI: paritytech/try-runtime-cli#6

Removing the tests at the same time because to reduce load on the CI, they take a long time to run. Tests are migrated to the new repo.

polkadot companion: paritytech/polkadot#7599

TODO before merge

@liamaharon liamaharon added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 8, 2023
utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved
@liamaharon liamaharon marked this pull request as ready for review August 8, 2023 10:58
utils/frame/try-runtime/cli/src/lib.rs Outdated Show resolved Hide resolved
@liamaharon liamaharon requested a review from a team as a code owner August 11, 2023 05:30
@liamaharon liamaharon added A0-please_review Pull request needs code review. and removed A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). labels Aug 11, 2023
Copy link
Contributor

@pmikolajczyk41 pmikolajczyk41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

scripts/ci/gitlab/pipeline/build.yml Outdated Show resolved Hide resolved
@liamaharon liamaharon added B1-note_worthy Changes should be noted in the release notes T0-node This PR/Issue is related to the topic “node”. and removed B0-silent Changes should not be mentioned in any release notes labels Aug 16, 2023
@paritytech-ci paritytech-ci requested a review from a team August 16, 2023 08:29
scripts/ci/gitlab/pipeline/build.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team August 16, 2023 08:57
@liamaharon
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for b550ff4

@liamaharon
Copy link
Contributor Author

bot merge force

@paritytech-processbot paritytech-processbot bot merged commit aa70241 into master Aug 17, 2023
3 checks passed
@paritytech-processbot paritytech-processbot bot deleted the liam-try-runtime-cli-deprecation-notice branch August 17, 2023 05:23
Ank4n pushed a commit that referenced this pull request Aug 20, 2023
…#14731)

* add deprecation notice

* remove try-runtime-cli tests

* update docs

* add estimated removal date

* deprecate and remove from node-cli and node-template

* try fix build script

* update comment

* fix link

* typo in build script

* Move `try-runtime-cli` install step outside of `check_dependent_project.sh` execution scope

* Update scripts/ci/gitlab/pipeline/build.yml

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* remove chain arg

* build runtime with try-runtime feature

* kick ci

* kick ci

* use main branch

* specify sha in try-runtime-cli cargo install

* kick ci

* kick ci

---------

Co-authored-by: Vladimir Istyufeev <vladimir@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants