This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix CI check and remove try-runtime command #3046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(preparation for the monorepo) Warnings should be treated as errors here, since this is how it will be done in the monorepo. I expect to see two errors in this check now. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
B0-silent
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
@ggwpez I just removed the commands from polkadot and substrate clis instead of allowing deprecated. Maybe we can do the same with cumulus? |
|
Ah okay, yes i will change it. |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
bkchr
approved these changes
Aug 23, 2023
rcny
approved these changes
Aug 23, 2023
ggwpez
changed the title
try-runtime check
ggwpez
added
A0-please_review
altaua
approved these changes
Aug 23, 2023
|
bot merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(preparation for the monorepo)
Changes;
cargo-check-try-runtimeCI should be treated as errors, since this is how it will be done in the monorepo.try-runtimesubcommand and direct users to standalone cli substrate#14731