Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make frame-support compile #13825

Closed
wants to merge 3 commits into from
Closed

Make frame-support compile #13825

wants to merge 3 commits into from

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Apr 5, 2023

frame-support benchmark tests do not compile on master otherwise.

@ggwpez
Make frame-support compile
7141b22 
frame-support benchmark tests do not compile on master otherwise.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 5, 2023
@ggwpez ggwpez requested a review from liamaharon April 5, 2023 09:32
@ggwpez ggwpez marked this pull request as ready for review April 5, 2023 09:32
liamaharon
liamaharon approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed thanks 👌

@bkchr
Copy link
Member

bkchr commented Apr 5, 2023

check-crate-publishing is failing because of this: paritytech/releng-scripts#37

@ggwpez
Copy link
Member Author

ggwpez commented Apr 5, 2023

check-crate-publishing is failing because of this: paritytech/releng-scripts#37

What is the work-around?

@bkchr
Copy link
Member

bkchr commented Apr 5, 2023

check-crate-publishing is failing because of this: paritytech/releng-scripts#37

What is the work-around?

Fixing this issue 🙈

@ggwpez
Remove frame-system dependency
01583c8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Revert "Remove frame-system dependency"
a7334c4 
It is only used in doc-tests for the outdated decl_ syntax 🤦

This reverts commit 01583c8.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Apr 12, 2023

Going to close this as "Blocked" until we have fixed that publish script.
It is full of bash so I wont touch it 😢

@ggwpez ggwpez closed this Apr 12, 2023
@ggwpez ggwpez added the S4-blocked Issue is blocked, see comments for further information. label Apr 12, 2023
@ggwpez ggwpez deleted the oty-fix-frame-support-feature branch May 9, 2023 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@bkchr bkchr bkchr approved these changes

@liamaharon liamaharon liamaharon approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit S4-blocked Issue is blocked, see comments for further information.
Projects
Runtime / FRAME
Status: To Do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggwpez @bkchr @KiChjang @liamaharon