Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish-crates: Strip features belonging to dev-dependencies #37

Open
bkchr opened this issue Mar 13, 2023 · 1 comment
Open

publish-crates: Strip features belonging to dev-dependencies #37

bkchr opened this issue Mar 13, 2023 · 1 comment
Assignees
@Morganamilo
Labels
bug Something isn't working

Comments

@bkchr
Copy link
Member

bkchr commented Mar 13, 2023

We are already stripping dev-dependencies before publishing to crates.io, at the same time we also should remove enabling of features these dev-dependencies. This should fix the CI failures we are currently seeing: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2513783
@niklasad1
Copy link
Member

niklasad1 commented Mar 13, 2023 •
edited
Loading

cargo hack already supports that by $ cargo hack publish --no-dev-deps --allow-dirty

Any reason why not to use it?

@coderobe coderobe added the bug Something isn't working label Mar 13, 2023
@altaua altaua mentioned this issue Mar 21, 2023
Merged
@bkchr bkchr mentioned this issue Apr 5, 2023
Closed
Morganamilo added a commit to paritytech/subpub that referenced this issue Jun 1, 2023
@Morganamilo
Strip features pointing to dev-deps before publish
24b1fe6 
Fixes paritytech/releng-scripts#37
@Morganamilo Morganamilo mentioned this issue Jun 1, 2023
Merged
Morganamilo added a commit to paritytech/subpub that referenced this issue Jun 1, 2023
@Morganamilo
Strip features pointing to dev-deps before publish
24ffc72 
Fixes paritytech/releng-scripts#37
Morganamilo added a commit to paritytech/subpub that referenced this issue Jun 2, 2023
@Morganamilo
Strip features pointing to dev-deps before publish
e0dfd3f 
Fixes paritytech/releng-scripts#37
Morganamilo added a commit to paritytech/subpub that referenced this issue Jun 13, 2023
@Morganamilo
Strip features pointing to dev-deps before publish (#14)
9933158 
Fixes paritytech/releng-scripts#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Morganamilo Morganamilo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bkchr @coderobe @niklasad1 @Morganamilo