Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Build wasm for mvp cpu #13758

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Build wasm for mvp cpu #13758

merged 1 commit into from
Mar 30, 2023

Conversation

athei
Copy link
Member

@athei athei commented Mar 29, 2023

In order to prevent wasm features being silently enabled with newer LLVM versions we want to set the target-cpu to mvp. We can still explicitly enable wasm features. Additionally, we get an explicit error if LLVM decides to remove MVP support.

Related: #13636

@athei athei requested a review from koute as a code owner March 29, 2023 15:31
@athei athei requested a review from bkchr March 29, 2023 15:31
@athei athei added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 29, 2023
@koute koute requested a review from a team March 29, 2023 15:32
@michalkucharczyk michalkucharczyk requested a review from a team March 29, 2023 15:57
@athei athei removed the A0-please_review Pull request needs code review. label Mar 30, 2023
@bkchr bkchr merged commit a0468b3 into master Mar 30, 2023
@bkchr bkchr deleted the at/wasm-mvp branch March 30, 2023 14:20
pgherveou pushed a commit that referenced this pull request Apr 4, 2023
gpestana pushed a commit that referenced this pull request Apr 23, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
sea212 pushed a commit to zeitgeistpm/substrate that referenced this pull request Aug 25, 2023
sea212 pushed a commit to zeitgeistpm/substrate that referenced this pull request Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants