Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust to latest nightly version and apply new clippy suggestions #1345

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update Rust to latest nightly version and apply new clippy suggestions #1345

merged 1 commit into from
Apr 3, 2023

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Apr 2, 2023

Code contributor checklist:

@nazar-pc nazar-pc requested a review from i1i1 April 2, 2023 13:40
liuchengxu
liuchengxu previously approved these changes Apr 2, 2023
View reviewed changes
@nazar-pc nazar-pc enabled auto-merge April 2, 2023 13:58
@nazar-pc
Copy link
Member Author

nazar-pc commented Apr 2, 2023

Need to upgrade Substrate to pull paritytech/substrate#13758 and finally resolve that unknown opcode error.

We can work around that on our side without Substrate upgrade, but I'd rather not if it is already fixed.

@nazar-pc nazar-pc disabled auto-merge April 2, 2023 16:01
@nazar-pc nazar-pc changed the base branch from main to update-substrate April 2, 2023 21:14
@nazar-pc
Copy link
Member Author

nazar-pc commented Apr 2, 2023

Rebased against update-substrate branch, this should fix WASM-related error on Ubuntu and other platforms

@nazar-pc nazar-pc requested a review from liuchengxu April 2, 2023 21:16
@nazar-pc nazar-pc requested a review from vedhavyas as a code owner April 2, 2023 21:27
@nazar-pc nazar-pc marked this pull request as draft April 3, 2023 00:04
@nazar-pc
Copy link
Member Author

nazar-pc commented Apr 3, 2023

Works for me overall except fraud proof test doesn't complete:

        SLOW [> 60.000s] subspace-fraud-proof tests::invalid_execution_proof_should_not_work
        SLOW [>120.000s] subspace-fraud-proof tests::invalid_execution_proof_should_not_work
        SLOW [>180.000s] subspace-fraud-proof tests::invalid_execution_proof_should_not_work
        SLOW [>240.000s] subspace-fraud-proof tests::invalid_execution_proof_should_not_work
        SLOW [>300.000s] subspace-fraud-proof tests::invalid_execution_proof_should_not_work
        SLOW [>360.000s] subspace-fraud-proof tests::invalid_execution_proof_should_not_work

@liuchengxu @NingLin-P I'll need your help here

@nazar-pc nazar-pc marked this pull request as ready for review April 3, 2023 12:05
@nazar-pc nazar-pc mentioned this pull request Apr 3, 2023
Merged
1 task
Base automatically changed from update-substrate to main April 3, 2023 15:31
@nazar-pc nazar-pc merged commit 96fd56e into main Apr 3, 2023
@nazar-pc nazar-pc deleted the update-rust branch April 3, 2023 15:31
i1i1 added a commit to autonomys/subspace-pulsar-sdk that referenced this pull request Apr 4, 2023
@i1i1
Import autonomys/subspace#1345
e4c34d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhavyas vedhavyas vedhavyas approved these changes

@rg3l3dr rg3l3dr Awaiting requested review from rg3l3dr rg3l3dr is a code owner

@i1i1 i1i1 Awaiting requested review from i1i1

@liuchengxu liuchengxu Awaiting requested review from liuchengxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nazar-pc @vedhavyas @liuchengxu