This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
added
A3-in_progress
Pull request is in progress. No review needed at this stage.
B0-silent
Changes should not be mentioned in any release notes
C3-medium
PR touches the given topic and has a medium impact on builders.
labels
Nov 1, 2021
github-actions
bot
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Nov 1, 2021
sergejparity
previously approved these changes
Nov 1, 2021
gilescope
added
the
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
label
Nov 1, 2021
bkchr
approved these changes
Nov 3, 2021
rcny
approved these changes
Nov 3, 2021
TriplEight
approved these changes
Nov 3, 2021
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* Update CI image to the latest rustc * Update rustc error messages * whitespace * update test output * updating compiler errors * kid's finally learning to read and spots the TRYBUILD=overwrite message. * undoing a little blessing * imperfect error msg * revert ci image to production Co-authored-by: gilescope <gilescope@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* Update CI image to the latest rustc * Update rustc error messages * whitespace * update test output * updating compiler errors * kid's finally learning to read and spots the TRYBUILD=overwrite message. * undoing a little blessing * imperfect error msg * revert ci image to production Co-authored-by: gilescope <gilescope@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C3-medium
PR touches the given topic and has a medium impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opened this PR in order to update CI image. Currently production CI image has rustc version 1.55. In order to upgrade rustc to version 1.56.1 these tests should be fixed:
https://gitlab.parity.io/parity/substrate/-/jobs/1198251
https://gitlab.parity.io/parity/substrate/-/jobs/1198256
So the current plan is:
staging
version with rustc 1.56.1 in .gitlab-ci.ymlstaging
ci image toproduction
production
in .gitlab-ci.ymlpolkadot: paritytech/polkadot#4200