-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we have this documented somewhere? #8
Comments
Cumulus depends on both Substrate and Polkadot, while Polkadot only depends on Substrate
In that case the Polkadot PR's reference should have been ignored because Substrate is not one of its dependents. If it it did not behave this way, then the implementation is incorrect. |
If a companion is not specified in the description, then it is assumed that the PR's branch does not break the dependency's master code, whatever that is. This assumption is validated through the check, hence why it does not bail out even if the companion is not specified. |
A high-level behavior/motivation should be drafted, not only for this script, but the companion build system as a whole. I had to learn second-hand about how it worked on one of my first weeks at Parity because there was no mention whatsoever of "companion" during my onboarding process. The Substrate contributing guidelines explains companions from a usage perspective but I am not aware of any document explaining how and why this system works the way it does. To this day I still do not know who designed the companion build system or the reasoning behind some of its inherently flawed behavior. An explanation attempt was made at paritytech/parity-processbot#327 but
A holistic explanation might also benefit the system in allowing for improvements suggestions since more people will be able to understand it. |
Is there a source of truth for this job?
I mean, there are jobs: https://github.com/paritytech/substrate/blob/master/.gitlab-ci.yml#L582-L590
and https://github.com/paritytech/polkadot/blob/master/.gitlab-ci.yml#L275-L294
Companion: #number
. It's OK if they would just run to check if there is a companion and exit, why checking if a companion is not mentioned?The text was updated successfully, but these errors were encountered: