Customize schedule with runtime memory limit suitable for development node #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agryaznov
requested review from
a team,
cmichi,
ascjones,
HCastano and
athei
as code owners
agryaznov
changed the title
agryaznov
changed the title
juangirini
approved these changes
May 29, 2023
hummusonrails
pushed a commit
to hummusonrails/substrate-contracts-node
that referenced
this pull request
Jun 5, 2023
… node (paritytech#187) In recent PR paritytech#182 (comment), the CI step of running `cargo test` was commented out as a dirty workaround for the pallet contracts integrity test failure. The test checks that the pallet configuration is memory safe. So to make the test pass, we enlarge the runtime memory limit in the Schedule. We do this because this development node [allows](https://github.com/paritytech/substrate-contracts-node/blob/8d13ddef3f5c728d1661e79c511a28cef206b298/runtime/src/lib.rs#L367) larger contract size than it is normally allowed in a production running node. This should be fine for the development node where possible security implications could be neglected for the sake of development convenience. **However, please DO NOT do this to your production node config, unless you are sure that the limit you're setting is the real memory limit of your runtime**.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent PR #182 (comment), the CI step of running
cargo testwas commented out as a dirty workaround for the pallet contracts integrity test failure. The test checks that the pallet configuration is memory safe.So to make the test pass, we enlarge the runtime memory limit in the Schedule. We do this because this development node allows larger contract size than it is normally allowed in a production running node. This should be fine for the development node where possible security implications could be neglected for the sake of development convenience. However, please DO NOT do this to your production node config, unless you are sure that the limit you're setting is the real memory limit of your runtime.