Sync with polkadot-v0.9.42 branch #182
Conversation
SkymanOne
requested review from
cmichi,
HCastano,
athei,
ascjones and
agryaznov
as code owners
|
CI needs fixing |
|
It is the integrity_test which fails because our allowed code size is too big for the max call stack depth. We either disable the test or we need to make a change in pallet-contracts to make the memory limit configurable. |
|
I temporarily disabled |
It is configurable since substrate#13565 is merged, via |
Nice. We can enable the test with the next release then. |
… node (#187) In recent PR #182 (comment), the CI step of running `cargo test` was commented out as a dirty workaround for the pallet contracts integrity test failure. The test checks that the pallet configuration is memory safe. So to make the test pass, we enlarge the runtime memory limit in the Schedule. We do this because this development node [allows](https://github.com/paritytech/substrate-contracts-node/blob/8d13ddef3f5c728d1661e79c511a28cef206b298/runtime/src/lib.rs#L367) larger contract size than it is normally allowed in a production running node. This should be fine for the development node where possible security implications could be neglected for the sake of development convenience. **However, please DO NOT do this to your production node config, unless you are sure that the limit you're setting is the real memory limit of your runtime**.
… node (paritytech#187) In recent PR paritytech#182 (comment), the CI step of running `cargo test` was commented out as a dirty workaround for the pallet contracts integrity test failure. The test checks that the pallet configuration is memory safe. So to make the test pass, we enlarge the runtime memory limit in the Schedule. We do this because this development node [allows](https://github.com/paritytech/substrate-contracts-node/blob/8d13ddef3f5c728d1661e79c511a28cef206b298/runtime/src/lib.rs#L367) larger contract size than it is normally allowed in a production running node. This should be fine for the development node where possible security implications could be neglected for the sake of development convenience. **However, please DO NOT do this to your production node config, unless you are sure that the limit you're setting is the real memory limit of your runtime**.
This PR syncs with the
polkadot-v0.9.42branch.