Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

backport minimum weight to fee to master #5739

Merged
merged 7 commits into from
Jun 29, 2022
Merged

backport minimum weight to fee to master #5739

merged 7 commits into from
Jun 29, 2022

Conversation

kianenigma
Copy link
Contributor

backports #5738 to master.

This slightly increases the adjustment of weight fee, and more importantly increases the minimum value of weight to fee multiplier to 0.1, instead of being a near-zero value.

This has no impact on fees, since the weight fee is so small now that it has no effect.

Example of transfer fee with different weight multipliers:

multiplier = FixedU128(0.100000000000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 1574520 }), tip: 0 } // final fee = "151,574,520"
multiplier = FixedU128(1.000000000000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 15745200 }), tip: 0 } // final fee = "165,745,200"
multiplier = FixedU128(0.100000000000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 1574520 }), tip: 0 } // final fee = "151,574,520"
multiplier = FixedU128(0.010000000000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 157452 }), tip: 0 } // final fee = "150,157,452"
multiplier = FixedU128(0.001000000000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 15745 }), tip: 0 } // final fee = "150,015,745"
multiplier = FixedU128(0.000001000000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 15 }), tip: 0 } // final fee = "150,000,015"
multiplier = FixedU128(0.000000001000000000) // fee details = FeeDetails { inclusion_fee: Some(InclusionFee { base_fee: 10000000, len_fee: 140000000, adjusted_weight_fee: 0 }), tip: 0 } // final fee = "150,000,000"

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jun 29, 2022
@paritytech-ci paritytech-ci requested review from a team June 29, 2022 12:24
@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 929fec6

@kianenigma
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit eb21d7c into master Jun 29, 2022
@paritytech-processbot paritytech-processbot bot deleted the kiz-fix-fees branch June 29, 2022 20:26
pepoviola pushed a commit that referenced this pull request Jul 3, 2022
@kianenigma @pepoviola
backport minimum weight to fee to master (#5739)
979ba30 
* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again
ordian added a commit that referenced this pull request Jul 5, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
650eb19 
* master:
  Fix regexp to find the repo name (#5751)
  Limit stagnant checks to a certain amount of entries (#5742)
  fix(staking miner): check latest state in solution (#5744)
  staking-miner: CLI flag delay solution x secs (#5734)
  backport minimum weight to fee to master (#5739)
  Bump quote from 1.0.19 to 1.0.20 (#5736)
paritytech-processbot bot pushed a commit that referenced this pull request Jul 5, 2022
@pepoviola @sandreim
@alvicsam @dependabot @kianenigma @niklasad1 @dvdplm @chevdor
[Zombienet] test deregister validator (#5718)
fb2c9ae 
* Update metric name and doc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* add test and rename metric to use

* change within time for test

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Properly format the stash account

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* Update test

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* change metric name

* Bump quote from 1.0.19 to 1.0.20 (#5736)

Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20.
- [Release notes](https://github.com/dtolnay/quote/releases)
- [Commits](dtolnay/quote@1.0.19...1.0.20)

---
updated-dependencies:
- dependency-name: quote
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* backport minimum weight to fee to master (#5739)

* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again

* staking-miner: CLI flag delay solution x secs (#5734)

* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>

* fix(staking miner): check latest state in solution (#5744)

* bump zombienet version and fix test

* Update zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Update zombienet_tests/smoke/0003-deregister-register-validator.js

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
ordian added a commit that referenced this pull request Jul 12, 2022
@ordian
Merge branch 'master' into bernhard-split-network-bridge-into-two-sub…
687ae9a 
…systems

* master: (39 commits)
  Implement prune only stagnant check mode (#5761)
  Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769)
  Update release-99_bot.yml (#5764)
  Version bump to v0.9.26/9260 (#5755)
  Rename `extra_constant` (#5749)
  Bump wasmtime from 0.38.0 to 0.38.1 (#5741)
  Several small fixes to the templates of the release notes (#5756)
  Backports from 0.9.25 (#5754)
  Remove bridges subtree (#5752)
  [Zombienet] test deregister validator (#5718)
  Fix regexp to find the repo name (#5751)
  Limit stagnant checks to a certain amount of entries (#5742)
  fix(staking miner): check latest state in solution (#5744)
  staking-miner: CLI flag delay solution x secs (#5734)
  backport minimum weight to fee to master (#5739)
  Bump quote from 1.0.19 to 1.0.20 (#5736)
  zombienet: try to fix parachains upgrade test (#5724)
  Update dependencies (companion for substrate#11722) (#5731)
  Update metric name and doc (#5716)
  Bump reqwest from 0.11.10 to 0.11.11 (#5732)
  ...
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@kianenigma
backport minimum weight to fee to master (#5739)
8c692d1 
* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@pepoviola @sandreim
@alvicsam @dependabot @kianenigma @niklasad1 @dvdplm @chevdor
[Zombienet] test deregister validator (#5718)
0d1f8f8 
* Update metric name and doc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* add test and rename metric to use

* change within time for test

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Properly format the stash account

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* Update test

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* change metric name

* Bump quote from 1.0.19 to 1.0.20 (#5736)

Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20.
- [Release notes](https://github.com/dtolnay/quote/releases)
- [Commits](dtolnay/quote@1.0.19...1.0.20)

---
updated-dependencies:
- dependency-name: quote
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* backport minimum weight to fee to master (#5739)

* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again

* staking-miner: CLI flag delay solution x secs (#5734)

* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>

* fix(staking miner): check latest state in solution (#5744)

* bump zombienet version and fix test

* Update zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Update zombienet_tests/smoke/0003-deregister-register-validator.js

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@andresilva andresilva andresilva approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kianenigma @dvdplm @andresilva @shawntabrizi