Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Zombienet] test deregister validator #5718

Merged
merged 18 commits into from
Jul 5, 2022
Merged

[Zombienet] test deregister validator #5718

merged 18 commits into from
Jul 5, 2022

Conversation

pepoviola
Copy link
Contributor

ping @sandreim
This add one test to check the correct value of polkadot_node_is_active_validator.

Thanks!

@pepoviola pepoviola requested a review from sandreim June 22, 2022 18:23
@pepoviola pepoviola requested a review from a team as a code owner June 22, 2022 18:23
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Jun 22, 2022
@pepoviola pepoviola added I5-tests Tests need fixing, improving or augmenting. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 22, 2022
@sandreim sandreim mentioned this pull request Jun 23, 2022
Merged
@sandreim
Copy link
Contributor

There is an error at startup - Error: Invalid chain spec raw file generated. Maybe related to zombienet:v1.2.42 ?

sandreim
sandreim reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alvicsam
alvicsam suggested changes Jun 23, 2022
View reviewed changes
.gitlab-ci.yml Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team June 23, 2022 09:40
@pepoviola @alvicsam
Update .gitlab-ci.yml
0eac156 
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
alvicsam
alvicsam suggested changes Jun 23, 2022
View reviewed changes
.gitlab-ci.yml Outdated Show resolved Hide resolved
@paritytech-ci paritytech-ci requested a review from a team June 23, 2022 10:22
@pepoviola @alvicsam
Update .gitlab-ci.yml
2601276 
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
@paritytech-ci paritytech-ci requested a review from a team June 23, 2022 10:25
@sandreim
Properly format the stash account
fee7b96 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Update test
6f870b4 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
@sandreim
Copy link
Contributor

@pepoviola I've fixed an issue in the JS (the stash account was wrong), but the test keeps failing. It seems to be some sort of issue with metric fetching in Zombienet.

1) ( Deregister / Register Validator Smoke )
       dave: reports polkadot_node_is_active_validator is 0 within 180 secs:

      AssertionError: expected 1 to equal 0
      + expected - actual

      -1
      +0

At the same time I query the respective node metric endpoint and I get:

# HELP polkadot_node_is_active_validator Tracks if the validator is in the active set. Updates at session boundary.
# TYPE polkadot_node_is_active_validator gauge
polkadot_node_is_active_validator{chain="rococo_local_testnet"} 0

@sandreim sandreim mentioned this pull request Jun 27, 2022
Closed
@pepoviola
Copy link
Contributor Author

@pepoviola I've fixed an issue in the JS (the stash account was wrong), but the test keeps failing. It seems to be some sort of issue with metric fetching in Zombienet.

1) ( Deregister / Register Validator Smoke )
       dave: reports polkadot_node_is_active_validator is 0 within 180 secs:

      AssertionError: expected 1 to equal 0
      + expected - actual

      -1
      +0

At the same time I query the respective node metric endpoint and I get:

# HELP polkadot_node_is_active_validator Tracks if the validator is in the active set. Updates at session boundary.
# TYPE polkadot_node_is_active_validator gauge
polkadot_node_is_active_validator{chain="rococo_local_testnet"} 0

Ahh thanks for the fix! Checking the metrics cache now.
Thx!

@paritytech-ci paritytech-ci requested a review from a team June 28, 2022 09:09
Base automatically changed from sandreim/fix_metric_confusion to master June 28, 2022 09:10
sandreim and others added 6 commits June 28, 2022 09:19
@sandreim
Merge branch 'master' of github.com:paritytech/polkadot into zombiene…
257be74 
…t-test-deregister-validator
@dependabot @pepoviola
Bump quote from 1.0.19 to 1.0.20 (#5736)
6fbc92d 
Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20.
- [Release notes](https://github.com/dtolnay/quote/releases)
- [Commits](dtolnay/quote@1.0.19...1.0.20)

---
updated-dependencies:
- dependency-name: quote
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kianenigma @pepoviola
backport minimum weight to fee to master (#5739)
979ba30 
* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again
@niklasad1 @dvdplm @pepoviola
staking-miner: CLI flag delay solution x secs (#5734)
83baccb 
* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>
@niklasad1 @pepoviola
fix(staking miner): check latest state in solution (#5744)
d5526ae
@pepoviola
bump zombienet version and fix test
b42e9b5
@paritytech-ci paritytech-ci requested review from a team July 3, 2022 13:37
@pepoviola pepoviola marked this pull request as draft July 3, 2022 13:39
@pepoviola pepoviola marked this pull request as ready for review July 3, 2022 13:53
@pepoviola
Copy link
Contributor Author

ping @sandreim deregister/register test fixed.
Thanks!

chevdor
chevdor approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the 2 missing EOF

zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml Outdated Show resolved Hide resolved
zombienet_tests/smoke/0003-deregister-register-validator.js Outdated Show resolved Hide resolved
sandreim and others added 2 commits July 4, 2022 12:05
@sandreim @chevdor
Update zombienet_tests/smoke/0003-deregister-register-validator-smoke…
3531fa4 
….toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@sandreim @chevdor
Update zombienet_tests/smoke/0003-deregister-register-validator.js
94da821 
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@sandreim sandreim self-requested a review July 5, 2022 12:18
@sandreim
Copy link
Contributor

sandreim commented Jul 5, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit fb2c9ae into master Jul 5, 2022
@paritytech-processbot paritytech-processbot bot deleted the zombienet-test-deregister-validator branch July 5, 2022 18:43
ordian added a commit that referenced this pull request Jul 12, 2022
@ordian
Merge branch 'master' into bernhard-split-network-bridge-into-two-sub…
687ae9a 
…systems

* master: (39 commits)
  Implement prune only stagnant check mode (#5761)
  Bump chevdor/srtool-actions from 0.4.0 to 0.5.0 (#5769)
  Update release-99_bot.yml (#5764)
  Version bump to v0.9.26/9260 (#5755)
  Rename `extra_constant` (#5749)
  Bump wasmtime from 0.38.0 to 0.38.1 (#5741)
  Several small fixes to the templates of the release notes (#5756)
  Backports from 0.9.25 (#5754)
  Remove bridges subtree (#5752)
  [Zombienet] test deregister validator (#5718)
  Fix regexp to find the repo name (#5751)
  Limit stagnant checks to a certain amount of entries (#5742)
  fix(staking miner): check latest state in solution (#5744)
  staking-miner: CLI flag delay solution x secs (#5734)
  backport minimum weight to fee to master (#5739)
  Bump quote from 1.0.19 to 1.0.20 (#5736)
  zombienet: try to fix parachains upgrade test (#5724)
  Update dependencies (companion for substrate#11722) (#5731)
  Update metric name and doc (#5716)
  Bump reqwest from 0.11.10 to 0.11.11 (#5732)
  ...
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@pepoviola @sandreim
@alvicsam @dependabot @kianenigma @niklasad1 @dvdplm @chevdor
[Zombienet] test deregister validator (#5718)
0d1f8f8 
* Update metric name and doc

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* add test and rename metric to use

* change within time for test

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Update .gitlab-ci.yml

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

* Properly format the stash account

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* Update test

Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* change metric name

* Bump quote from 1.0.19 to 1.0.20 (#5736)

Bumps [quote](https://github.com/dtolnay/quote) from 1.0.19 to 1.0.20.
- [Release notes](https://github.com/dtolnay/quote/releases)
- [Commits](dtolnay/quote@1.0.19...1.0.20)

---
updated-dependencies:
- dependency-name: quote
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* backport minimum weight to fee to master (#5739)

* propose fix fees

* add tests to kusama runtime as well

* better tests

* last change

* last update

* Fix test

* ignore tests again

* staking-miner: CLI flag delay solution x secs (#5734)

* staking-miner: CLI flag delay solution x secs

* Update utils/staking-miner/src/monitor.rs

* Update utils/staking-miner/src/opts.rs

* more logging

* add more verbose logging

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* Update utils/staking-miner/src/opts.rs

Co-authored-by: David <dvdplm@gmail.com>

* remove redundant check

Co-authored-by: David <dvdplm@gmail.com>

* fix(staking miner): check latest state in solution (#5744)

* bump zombienet version and fix test

* Update zombienet_tests/smoke/0003-deregister-register-validator-smoke.toml

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

* Update zombienet_tests/smoke/0003-deregister-register-validator.js

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>

Co-authored-by: Andrei Sandu <andrei-mihail@parity.io>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
Co-authored-by: David <dvdplm@gmail.com>
Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
@librelois librelois mentioned this pull request Jul 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sandreim sandreim sandreim approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. I5-tests Tests need fixing, improving or augmenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pepoviola @sandreim @chevdor @alvicsam @kianenigma @niklasad1