Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix path of the polkadot sha256 #4458

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Fix path of the polkadot sha256 #4458

merged 1 commit into from
Dec 3, 2021

Conversation

chevdor
Copy link
Contributor

@chevdor chevdor commented Dec 3, 2021

The build script for Polkadot creates a sha256 similar to:

91ac4f668e84c05c98542734c37eee21f74de1e9f35982186e87343bcbc7897d  ./artifacts/polkadot

That makes it inconvenient for users who probably do not have this artifacts sub-folder and cannot check the sha56 using a simple:

shasum -c polkadot.sha256

without modifying the checksum file.

This PR fixes that, allowing users to download the binary and the sha256 and immediately check the binary without extra trickery.

@chevdor chevdor requested a review from a team as a code owner December 3, 2021 13:35
@chevdor chevdor requested a review from s3krit December 3, 2021 13:35
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Dec 3, 2021
@chevdor chevdor added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Dec 3, 2021
@chevdor chevdor merged commit 472f245 into master Dec 3, 2021
@chevdor chevdor deleted the wk-fix-sha256 branch December 3, 2021 15:59
ordian added a commit that referenced this pull request Dec 3, 2021
* master: (23 commits)
  Fix path of the polkadot_injected docker image (#4463)
  update docs on `validation_upgrade_frequency` (#4460)
  Fix path of the polkadot sha256 (#4458)
  Fix cumulus companion CI job (#4451)
  Add doc about runtime version bump (#4418)
  Bump trybuild from 1.0.52 to 1.0.53 (#4455)
  companion for #10231 (#4306)
  trivial fix (#4441)
  Rococo: ability to programatically assign slots to teams (#3943)
  Add parent header hash to log (#4421)
  bump tx versions (#4447)
  Companion for substrate/10347 (#4413)
  Improve paras runtime `BenchBuilder` api (#4318)
  Add CI team to `CODEOWNERS` file (#4350)
  XCM Benchmarks for Generic Instructions (#3940)
  Announce only on releases (#4417)
  Companion for  10379 (EnsureOneOf) (#4405)
  add pallet-babe/std (#4438)
  update Cargo.lock
  Squashed 'bridges/' changes from 407bf44a8a..1602249f0a
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants