Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump tx versions #4447

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Bump tx versions #4447

merged 1 commit into from
Dec 2, 2021

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Dec 2, 2021 •
edited by bkchr
Loading

The check_transaction_versions job seemingly didn't correctly detect that we have had metadata changes that require a bump to the transaction version. I'll file a separate issue to track fixing that CI job.

Polkadot, Westend and Kusama have all had runtime changes necessitating a bump to the transaction version. In short:

Polkadot:

     [Spec] name: polkadot
            spec_version: 9120 -> 9130
            transaction_version: 8
 [Metadata] version: 14
  [Modules] num: 46 -> 48
            [+] modules: BagsList, XcmPallet

                 [System] idx: 0 (calls: 10 -> 9, storage: 17)
                          [-] calls: setChangesTrieConfig
                           [setStorage] idx: 6 -> 5 (args: 1)
                                        (Vec<(Bytes,Bytes)>)
                          [killStorage] idx: 7 -> 6 (args: 1)
                                        (Vec<Bytes>)
                           [killPrefix] idx: 8 -> 7 (args: 2)
                                        (Bytes, u32)
                      [remarkWithEvent] idx: 9 -> 8 (args: 1)
                                        (Bytes)

Kusama:

    [Spec] name: kusama
           spec_version: 9120 -> 9130
           transaction_version: 7
[Metadata] version: 14
 [Modules] num: 51 -> 52
           [+] modules: ParasDisputes

                [System] idx: 0 (calls: 10 -> 9, storage: 17)
                         [-] calls: setChangesTrieConfig
                          [setStorage] idx: 6 -> 5 (args: 1)
                                       (Vec<(Bytes,Bytes)>)
                         [killStorage] idx: 7 -> 6 (args: 1)
                                       (Vec<Bytes>)
                          [killPrefix] idx: 8 -> 7 (args: 2)
                                       (Bytes, u32)
                     [remarkWithEvent] idx: 9 -> 8 (args: 1)
                                       (Bytes)

Westend:

    [Spec] name: westend
           spec_version: 9120 -> 9130
           transaction_version: 7
[Metadata] version: 14
 [Modules] num: 42

                [System] idx: 0 (calls: 10 -> 9, storage: 17)
                         [-] calls: setChangesTrieConfig
                          [setStorage] idx: 6 -> 5 (args: 1)
                                       (Vec<(Bytes,Bytes)>)
                         [killStorage] idx: 7 -> 6 (args: 1)
                                       (Vec<Bytes>)
                          [killPrefix] idx: 8 -> 7 (args: 2)
                                       (Bytes, u32)
                     [remarkWithEvent] idx: 9 -> 8 (args: 1)
                                       (Bytes)

skip check-dependent-cumulus

@s3krit s3krit added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Dec 2, 2021
@bkchr
Copy link
Member

bkchr commented Dec 2, 2021

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Checks failed for 54f8b9c

@bkchr bkchr merged commit 701250a into master Dec 2, 2021
@bkchr bkchr deleted the mp-bump-tx-version branch December 2, 2021 12:18
s3krit added a commit that referenced this pull request Dec 2, 2021
@s3krit
bump tx versions (#4447)
c82b46d
s3krit added a commit that referenced this pull request Dec 2, 2021
@s3krit
bump tx versions (#4447) (#4450)
0464e04
bkchr added a commit that referenced this pull request Dec 2, 2021
@bkchr @rphmeier
@shawntabrizi @NachoPal @apopiak @chevdor @xlc @zjb0807 @s3krit
Update Substrate branch (#4432)
7d8f00b 
* Update Substrate branch

* add disputes to Kusama runtime (#4356)

* add disputes to Kusama runtime

* Update DisputesHandler

* fmt

* add the benchmarks

* cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_disputes.rs

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Parity Bot <admin@parity.io>

* Add XCM pallet and config to Polkadot runtime (#4313)

* xcm added

* xcm pallet & config added Polkadot

* set advertise XCM version to 2 for Polkadot

* remove ChildSystemParachainAsSuperuser from Polkadot XCM config

* remove unpaid execution for system parachains

* remove unused imports

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* Pin changelogerator to the latest compatible version for the current flow (#4392) (#4436)

* add missing feature (#4355)

* add pallet-babe/std (#4438)

* Apply v0.9.13 weights (#4444)

* Update weights for Westend

* Update weights for kusama

* Update weights for polkadot

* bump tx versions (#4447) (#4450)

Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Parity Bot <admin@parity.io>
Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
Co-authored-by: Xiliang Chen <xlchen1291@gmail.com>
Co-authored-by: zjb0807 <zjb0807@qq.com>
Co-authored-by: Martin Pugh <martin@parity.io>
ordian added a commit that referenced this pull request Dec 3, 2021
@ordian
Merge branch 'master' into bernhardAssure_backed_candidates_are_sor
51dd597 
* master: (23 commits)
  Fix path of the polkadot_injected docker image (#4463)
  update docs on `validation_upgrade_frequency` (#4460)
  Fix path of the polkadot sha256 (#4458)
  Fix cumulus companion CI job (#4451)
  Add doc about runtime version bump (#4418)
  Bump trybuild from 1.0.52 to 1.0.53 (#4455)
  companion for #10231 (#4306)
  trivial fix (#4441)
  Rococo: ability to programatically assign slots to teams (#3943)
  Add parent header hash to log (#4421)
  bump tx versions (#4447)
  Companion for substrate/10347 (#4413)
  Improve paras runtime `BenchBuilder` api (#4318)
  Add CI team to `CODEOWNERS` file (#4350)
  XCM Benchmarks for Generic Instructions (#3940)
  Announce only on releases (#4417)
  Companion for  10379 (EnsureOneOf) (#4405)
  add pallet-babe/std (#4438)
  update Cargo.lock
  Squashed 'bridges/' changes from 407bf44a8a..1602249f0a
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

@joepetrowski joepetrowski Awaiting requested review from joepetrowski

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s3krit @bkchr @chevdor @kianenigma