This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Substrate companion: Authority discovery multiple peer ids #4295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authority discovery before had a fixed mapping from `PeerId` to `AuthorityId`. This wasn't correct, as a `PeerId` can actually map to multiple `AuthorityId`s. The linked Substrate pr fixes this. paritytech/substrate#10259
bkchr
added
A0-please_review
bkchr
commented
Nov 15, 2021
ordian
reviewed
Nov 15, 2021
| authorities.insert(authority, peer); | ||
| if let Some(authority_ids) = maybe_authority { | ||
| authority_ids.into_iter().for_each(|a| { | ||
| authorities.insert(a, peer); |
There was a problem hiding this comment.
The code here and the signature of authorities: &mut HashMap<AuthorityDiscoveryId, PeerId> still assumes one PeerId per AuthorityDiscoveryId. Should we also change it here and in gossip-support?
There was a problem hiding this comment.
Actually, it's not critical here, only used for prioritizing propagation to our group (priority_peers).
ordian
approved these changes
Nov 15, 2021
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 91c21cb |
ordian
added a commit
that referenced
this pull request
Nov 20, 2021
* master: (38 commits) Replicate Rob's PR (#4337) Companion for Taskmanager: Remove `clean_shutdown` (#4336) prefer code upgrades in inherent filtering (#4334) remove provisioner checks (#4254) Log para inherent inputs (#4331) Dispute spam protection (#4134) Dependabot: Ignore sub-tokens (#4328) export hrmp config (#4324) Add missing license header (#4321) Use non-empty validation code (#4322) fix pallet-xcm extrinsic doc comments (#4317) prepare worker: Catch unexpected unwinds (#4304) Enable BEEFY explicitly (#4320) Bump serde_json from 1.0.70 to 1.0.71 (#4316) Bump strum from 0.22.0 to 0.23.0 (#4308) Remove sort_unstable_by (#4314) Bump tokio from 1.13.0 to 1.14.0 (#4298) Substrate companion: Authority discovery multiple peer ids (#4295) Companion for substrate#9878 (#3949) move paras inherent filtering to runtime (#4028) ...
bkchr
added a commit
that referenced
this pull request
Nov 30, 2021
* Substrate companion: Authority discovery multiple peer ids Authority discovery before had a fixed mapping from `PeerId` to `AuthorityId`. This wasn't correct, as a `PeerId` can actually map to multiple `AuthorityId`s. The linked Substrate pr fixes this. paritytech/substrate#10259 * Update node/network/availability-distribution/src/requester/mod.rs * Update node/network/collator-protocol/src/validator_side/mod.rs * Update node/network/statement-distribution/src/tests.rs * Update guide * Adapt to Substrate pr * Update Substrate
23 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authority discovery before had a fixed mapping from
PeerIdtoAuthorityId. This wasn't correct, as aPeerIdcan actually map tomultiple
AuthorityIds. The linked Substrate pr fixes this.paritytech/substrate#10259
skip check-dependent-cumulus