Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

gossip: use all PeerIds per AuthorityId #4615

Closed
ordian opened this issue Dec 27, 2021 · 0 comments
Closed

gossip: use all PeerIds per AuthorityId #4615

ordian opened this issue Dec 27, 2021 · 0 comments
Labels
I3-bug Fails to follow expected behavior.

Comments

@ordian
Copy link
Member

ordian commented Dec 27, 2021

Even after #4295, in gossip protocols, we'd still use the first PeerId found in the mapping

let addr = get_peer_id_by_authority_id(

this helper function should be removed:

/// We assume one `peer_id` per `authority_id`.
pub async fn get_peer_id_by_authority_id<AD: AuthorityDiscovery>(
authority_discovery: &mut AD,
authority: AuthorityDiscoveryId,
) -> Option<PeerId> {

@ordian ordian added the I3-bug Fails to follow expected behavior. label Dec 27, 2021
@ordian ordian closed this as completed Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug Fails to follow expected behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant