Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

XCM simulator #3538

Merged
9 commits merged into from
Aug 1, 2021
Merged

XCM simulator #3538

9 commits merged into from
Aug 1, 2021

Conversation

shaunxw
Copy link
Contributor

@shaunxw shaunxw commented Aug 1, 2021

Compared to the original xcm-simulator, all cumulus dependencies are removed. The new impl uses XcmpMessageHandler and DmpMessageHandler abstractions, instead of directly calling cumulus pallets to handle xcmp and dmp. Users need to pass these implementations when declaring test parachain.

In order to make the new impl work, the following definitions are moved to polkadot from cumulus(will need a cumulus companion PR):

  • XcmpMessageHandler trait
  • DmpMessageHandler trait
  • XcmpMessageFormat enum

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. A0-please_review Pull request needs code review. labels Aug 1, 2021
apopiak
apopiak approved these changes Aug 1, 2021
View reviewed changes
Copy link
Contributor

@apopiak apopiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution to allow for integration testing 👍

xcm/xcm-simulator/src/lib.rs
Comment on lines +64 to +65
#[macro_export]
macro_rules! decl_test_relay_chain {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could add some doc comments for these macros.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets follow up on that :)

#3542

@shawntabrizi shawntabrizi mentioned this pull request Aug 1, 2021
Closed
@shawntabrizi
Copy link
Member

bot merge

@ghost
Copy link

ghost commented Aug 1, 2021

Trying merge.

@ghost ghost merged commit 4b2bd54 into paritytech:master Aug 1, 2021
@shawntabrizi shawntabrizi mentioned this pull request Aug 1, 2021
Closed
ordian added a commit that referenced this pull request Aug 2, 2021
@ordian
Merge branch 'master' into ao-subsystem-do-not-use-ourviewchange
4093836 
* master:
  Companion PR for warp sync support. (#3382)
  Companion for #9373 (Refactor Benchmarks for Wasm Memory) (#3549)
  XCM simulator (#3538)
  Parachains scheduler.rs to FrameV2 (#3529)
  Parachains session_info.rs to FrameV2 (#3521)
  Companion for substrate #9319 (#3456)
@shaunxw shaunxw deleted the sw/xcm-simulator branch August 3, 2021 02:54
@paxelpixel
Copy link

such a beautiful piece of code

This was referenced Aug 3, 2021
Closed
Merged
@shaunxw shaunxw mentioned this pull request Sep 27, 2022
Merged
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@apopiak apopiak apopiak approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaunxw @shawntabrizi @paxelpixel @apopiak