Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Parachains scheduler.rs to FrameV2 #3529

Merged
7 commits merged into from
Jul 31, 2021
Merged

Parachains scheduler.rs to FrameV2 #3529

7 commits merged into from
Jul 31, 2021

Conversation

ferrell-code
Copy link
Contributor

@ferrell-code ferrell-code commented Jul 28, 2021 •
edited
Loading

relates: #2882

Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.

⚠️ Breaking Change ⚠️

From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines

storages now use PalletInfo for module_prefix instead of the one given to decl_storage: Thus any use of this pallet in construct_runtime! should be careful to update name in order not to break storage or to upgrade storage (moreover for instantiable pallet). If pallet is published, make sure to warn about this breaking change.

So users of the ParaScheduler pallet must be careful about the name they used in construct_runtime!. Hence the runtime-migration label, which might not be needed depending on the configuration of the ParaScheduler pallet.

kusama and westend use ParasScheduler in construct_runtime!, so I migrated them to ParaScheduler

rococo uses Scheduler in construct_runtime!, it was migrated to ParaScheduler

polkadot does not use ParaScheduler.

@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 31, 2021
KiChjang
KiChjang reviewed Jul 31, 2021
View reviewed changes
runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
KiChjang
KiChjang reviewed Jul 31, 2021
View reviewed changes
runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved
@KiChjang
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Jul 31, 2021

Trying merge.

@ghost ghost merged commit 18de14d into paritytech:master Jul 31, 2021
@ferrell-code ferrell-code deleted the fer-scheduler-framev2 branch July 31, 2021 19:00
ordian added a commit that referenced this pull request Aug 2, 2021
@ordian
Merge branch 'master' into ao-subsystem-do-not-use-ourviewchange
4093836 
* master:
  Companion PR for warp sync support. (#3382)
  Companion for #9373 (Refactor Benchmarks for Wasm Memory) (#3549)
  XCM simulator (#3538)
  Parachains scheduler.rs to FrameV2 (#3529)
  Parachains session_info.rs to FrameV2 (#3521)
  Companion for substrate #9319 (#3456)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@KiChjang KiChjang KiChjang approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferrell-code @KiChjang @shawntabrizi