This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
paras.rs to FRAME V2 #3403
Merged
paras.rs to FRAME V2 #3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
added
A0-please_review
shawntabrizi
reviewed
Jul 5, 2021
| @@ -279,91 +262,45 @@ pub struct ParaGenesisArgs { | |||
| pub parachain: bool, | |||
| } | |||
|
|
|||
| decl_storage! { | |||
| trait Store for Module<T: Config> as Paras { | |||
There was a problem hiding this comment.
Pallet must always be imported as Paras for this to be backwards compatible
There was a problem hiding this comment.
Kusama, Westend, and Rococo look okay
There was a problem hiding this comment.
A re-export should be fine here, i.e. pub use pallet::Pallet as Paras
KiChjang
approved these changes
Jul 6, 2021
shawntabrizi
approved these changes
Jul 6, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit 
ordian
added a commit
that referenced
this pull request
Jul 6, 2021
* master: (33 commits) Update all weights, add run_all_benches.sh script (#3400) Enable over-bridge-messaging in Rococo/Wococo runtime (#3377) paras.rs to FRAME V2 (#3403) Add XCM Tracing (#3353) Use MaxEncodedLen trait from new parity-scale-codec v2.2 (#3412) bump a bunch of deps in parity-common (#3402) Warn on low connectivity. (#3408) origin to frame v2 (#3405) Enable logging in the puppet worker (#3411) make it easier to dbg stalls (#3351) XCM `canonicalize` + `prepend_with` fix (#3269) cleanup stream polls (#3397) Staking Miner (#3141) Companion for Substrate#8953 (#3140) Bump version, specs & substrate in prep for v0.9.8 (#3387) Fix busy loops. (#3392) Minor refactor (#3386) add simnet tests (#3381) BEEFY: adjust gossip (#3372) Companion for #9193 (#3376) ...
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates: #2882
Following the upgrade guidelines here: https://crates.parity.io/frame_support/attr.pallet.html#upgrade-guidelines.
From https://crates.parity.io/frame_support/attr.pallet.html#checking-upgrade-guidelines
So users of the
Paraspallet must be careful about the name they used inconstruct_runtime!. Hence theruntime-migration label, which might not be needed depending on the configuration of theParaspallet.Edit: Ok should work