Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bump version, specs & substrate in prep for v0.9.8 #3387

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Bump version, specs & substrate in prep for v0.9.8 #3387

merged 3 commits into from
Jul 1, 2021

Conversation

s3krit
Copy link
Contributor

@s3krit s3krit commented Jun 30, 2021

No description provided.

@s3krit s3krit added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jun 30, 2021
@s3krit s3krit requested review from chevdor and bkchr June 30, 2021 13:27
bkchr
bkchr approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No migrations to delete?

@chevdor
Copy link
Contributor

chevdor commented Jun 30, 2021 •
edited
Loading

You caught already a lot of versions that were "left" behind.
I saw that parity-util-mem is on 0.9.0 but it is not part of the source and it is the latest (https://github.com/paritytech/parity-common/tree/master/parity-util-mem).

I see a bunch of crates on 0.1.0 (78 of them), do we want to:

  • bump ALL crates no matter what
  • bump only what changed
  • option C

@bkchr
Copy link
Member

bkchr commented Jun 30, 2021

I saw that parity-util-mem is on 0.9.0 but it is not part of the source and it is the latest (https://github.com/paritytech/parity-common/tree/master/parity-util-mem).

What you mean by this? This is an extra crate?

@ordian
Copy link
Member

ordian commented Jun 30, 2021

@chevdor not sure what you mean, but parity-common crates have their own release schedule and they are published on crates.io, we update them as any other crates.io dependency here

@chevdor
Copy link
Contributor

chevdor commented Jun 30, 2021

All good, just checking what version was not bumped.

@chevdor
Copy link
Contributor

chevdor commented Jun 30, 2021 •
edited
Loading

So after checking the history, I think most (if not all) 0.1.0 should be bumped.
I prepared a branch to see which ones and the diff can be seen here: https://github.com/paritytech/polkadot/compare/mp-v0.9.8-prep...chevdor:wk-v0.9.8-prep?expand=1

@s3krit
Copy link
Contributor Author

s3krit commented Jun 30, 2021

No migrations to delete?

Nope, they got removed when #3347 was added

@chevdor
Copy link
Contributor

chevdor commented Jun 30, 2021

@bkchr @pepyakin
Do you have any objection bumping the 0.1.0 under node to 0.9.8 as well ? See diff here

@ordian
Copy link
Member

ordian commented Jun 30, 2021

BTW, what's the point of bumping versions (besides in the root Cargo.toml) if none of the crates are published to crates.io?

@s3krit
Copy link
Contributor Author

s3krit commented Jul 1, 2021

BTW, what's the point of bumping versions (besides in the root Cargo.toml) if none of the crates are published to crates.io?

Currently, I suppose there isn't much point, with the exception of whichever Cargo.toml affects the version shown in places like telemetry and console output (node/client/Cargo.toml?), and probably the runtimes too. That being said, it would be confusing to not bump packages which are already tracking relese versions from now on since during building you'll see 'Compiling polkadot-whatever vSuper.Old.Version'.

Regardless, we can discuss the best option to version our packages elsewhere, if it's ok with everyone I'm going to go ahead and merge this cause I'd like to get this release started :)

chevdor
chevdor approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the 0.1.0 topic can wait one more release

@s3krit s3krit merged commit ef1d192 into master Jul 1, 2021
@s3krit s3krit deleted the mp-v0.9.8-prep branch July 1, 2021 10:09
ordian added a commit that referenced this pull request Jul 2, 2021
@ordian
Merge branch 'master' into ao-dbg-unresponsiveness
efe630b 
* master: (21 commits)
  cleanup stream polls (#3397)
  Staking Miner (#3141)
  Companion for Substrate#8953 (#3140)
  Bump version, specs & substrate in prep for v0.9.8 (#3387)
  Fix busy loops. (#3392)
  Minor refactor (#3386)
  add simnet tests (#3381)
  BEEFY: adjust gossip (#3372)
  Companion for #9193 (#3376)
  Companion for Decouple Staking and Election - Part 3: Signed Phase (#2793)
  Ensure that we fetch another collation if the first collation was invalid (#3362)
  Only send one collation per relay parent at a time to validators (#3360)
  disable approval-checking-grandpa on dev chain (#3364)
  Use associated constant for max (#3375)
  Use wasm-builder from git (#3354)
  Squashed 'bridges/' changes from b2099c5..23dda62 (#3369)
  Bump versions & spec_versions (#3368)
  Don't allow bids for a ParaId where there is an overlapping lease period (#3361)
  Companion for upgrade of transaction-payment to pallet macro (#3267)
  Do not allow any crowdloan contributions during the VRF period (#3346)
  ...
ordian added a commit that referenced this pull request Jul 6, 2021
@ordian
Merge branch 'master' into rh-chain-selection-db-and-stagnant
8feb436 
* master: (33 commits)
  Update all weights, add run_all_benches.sh script (#3400)
  Enable over-bridge-messaging in Rococo/Wococo runtime (#3377)
  paras.rs to FRAME V2 (#3403)
  Add XCM Tracing (#3353)
  Use MaxEncodedLen trait from new parity-scale-codec v2.2 (#3412)
  bump a bunch of deps in parity-common (#3402)
  Warn on low connectivity. (#3408)
  origin to frame v2 (#3405)
  Enable logging in the puppet worker (#3411)
  make it easier to dbg stalls (#3351)
  XCM `canonicalize` + `prepend_with` fix (#3269)
  cleanup stream polls (#3397)
  Staking Miner (#3141)
  Companion for Substrate#8953 (#3140)
  Bump version, specs & substrate in prep for v0.9.8 (#3387)
  Fix busy loops. (#3392)
  Minor refactor (#3386)
  add simnet tests (#3381)
  BEEFY: adjust gossip (#3372)
  Companion for #9193 (#3376)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chevdor chevdor chevdor approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s3krit @chevdor @bkchr @ordian