Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2412] Backport #7446 #7462

Merged
merged 3 commits into from
Feb 5, 2025
Merged

[stable2412] Backport #7446 #7462

merged 3 commits into from
Feb 5, 2025

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #7446 into stable2412 from serban300.

See the documentation on how to use this bot.

@serban300 @github-actions
Fix duplicate codec indexes (#7446)
fd3981b 
Related to #7400 and
#7417

We need this in order to be able to update `parity-scale-codec` to the
latest version after it's released. That's because `parity-scale-codec`
added support for checking for duplicate indexes at compile time.

(cherry picked from commit 37446fc)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot requested a review from a team as a code owner February 5, 2025 08:54
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Feb 5, 2025
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@serban300 serban300 added the R0-silent Changes should not be mentioned in any release notes label Feb 5, 2025
@serban300 serban300 mentioned this pull request Feb 5, 2025
Merged
gui1117
gui1117 previously approved these changes Feb 5, 2025
View reviewed changes
ggwpez
ggwpez previously approved these changes Feb 5, 2025
View reviewed changes
@ggwpez
Copy link
Member

ggwpez commented Feb 5, 2025

/cmd prdoc --bump none --audience runtime_dev

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@serban300
Copy link
Contributor

/cmd prdoc --bump patch --audience runtime_dev

@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 5, 2025 12:31
@EgorPopelyaev EgorPopelyaev merged commit 4f37964 into stable2412 Feb 5, 2025
125 of 145 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7446-to-stable2412 branch February 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez left review comments

@gui1117 gui1117 gui1117 left review comments

Assignees

@serban300 serban300

Labels
A3-backport Pull request is already reviewed well in another branch. R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggwpez @serban300 @gui1117 @EgorPopelyaev