Fix duplicate codec indexes #7446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban300
added
R0-silent
serban300
force-pushed
the
small_fixes
branch
from
83259de to
ace68f6
Compare
acatangiu
approved these changes
Feb 4, 2025
gui1117
approved these changes
Feb 4, 2025
| @@ -209,6 +209,7 @@ pub fn expand_outer_origin( | |||
| system(#system_path::Origin<#runtime>), | |||
| #caller_variants | |||
| #[allow(dead_code)] | |||
| #[codec(skip)] | |||
| Void(#scrate::__private::Void) | |||
There was a problem hiding this comment.
For context: The void type can't be instantiated, it can't be decoded as well. So skipping the variant keeps the same behavior.
ggwpez
approved these changes
Feb 4, 2025
Merged
via the queue into
paritytech:master
with commit Feb 4, 2025
37446fc
208 of 212 checks passed
serban300
added
the
A4-needs-backport
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7446-to-stable2407
git worktree add --checkout .worktree/backport-7446-to-stable2407 backport-7446-to-stable2407
cd .worktree/backport-7446-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 37446fcbb05150cd304fde157f87e9004f203403
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-7446-to-stable2409
git worktree add --checkout .worktree/backport-7446-to-stable2409 backport-7446-to-stable2409
cd .worktree/backport-7446-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 37446fcbb05150cd304fde157f87e9004f203403
git push --force-with-lease |
|
Successfully created backport PR for |
serban300
had a problem deploying
to
subsystem-benchmarks
GitHub Actions
Failure
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 5, 2025
Backport #7446 into `stable2409` from serban300. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 5, 2025
Backport #7446 into `stable2407` from serban300. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Feb 5, 2025
Backport #7446 into `stable2412` from serban300. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Serban Iorga <serban@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7400 and #7417
We need this in order to be able to update
parity-scale-codecto the latest version after it's released. That's becauseparity-scale-codecadded support for checking for duplicate indexes at compile time.