Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add debug input for sync templates act #7057

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

iulianbarbu
Copy link
Contributor

@iulianbarbu iulianbarbu commented Jan 6, 2025

Description

Introduce a workflow debug input for misc-sync-templates.yml and use it instead of the runner.debug context variable, which is set to '1' when ACTIONS_RUNNER_DEBUG env/secret is set (https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/troubleshooting-workflows/enabling-debug-logging#enabling-runner-diagnostic-logging). This is useful for controlling when to show debug prints.

Integration

N/A

Review Notes

Using runner.debug requires setting the ACTIONS_RUNNER_DEBUG env variable, but setting it to false/true is doable through an input, or by importing a variable from the github env file (which requires a code change). This input alone can replace the entire runner.debug + ACTIONS_RUNNER_DEBUG setup, which simplifies debug printing, but it doesn't look as standard as runner.debug. I don't think it is a big deal overall, for this action alone, but happy to account for other opinions.

Note: setting the ACTIONS_RUNNER_DEBUG whenever we want in a separate branch wouldn't be useful because we can not run the misc-sync-templates.yml action from other branch than master (due to branch protection rules), so we need to expose this input to be controllable from master.

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@iulianbarbu iulianbarbu added the R0-silent Changes should not be mentioned in any release notes label Jan 6, 2025
@iulianbarbu iulianbarbu self-assigned this Jan 6, 2025
@iulianbarbu iulianbarbu requested review from a team as code owners January 6, 2025 13:10
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 6, 2025 14:05
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
@bkchr bkchr enabled auto-merge January 6, 2025 18:13
@bkchr bkchr added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit 1059be7 Jan 7, 2025
198 of 201 checks passed
@bkchr bkchr deleted the ib-enable-runner-debug-for-sync-templates-act branch January 7, 2025 09:47
ordian added a commit that referenced this pull request Jan 7, 2025
* master:
  workflows: add debug input for sync templates act (#7057)
  Remove usage of `sp-std` from Substrate (#7043)
  Fix typos (#7027)
  [core-fellowship] Add permissionless import_member (#7030)
  Avoid incomplete block import pipeline with full verifying import queue (#7050)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants