Avoid incomplete block import pipeline with full verifying import queue #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --bump patch --audience node_dev |
skunert
added
the
A4-needs-backport
dmitry-markin
approved these changes
Jan 6, 2025
michalkucharczyk
approved these changes
Jan 6, 2025
lexnv
approved these changes
Jan 6, 2025
bkchr
approved these changes
Jan 6, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…ue (#7050) ## Problem In the parachain template we use the [fully verifying import queue ](https://github.com/paritytech/polkadot-sdk/blob/3d9eddbeb262277c79f2b93b9efb5af95a3a35a8/cumulus/client/consensus/aura/src/equivocation_import_queue.rs#L224-L224) which does extra equivocation checks. However, when we import a warp synced block with state, we don't set a fork choice, leading to an incomplete block import pipeline and error here: https://github.com/paritytech/polkadot-sdk/blob/3d9eddbeb262277c79f2b93b9efb5af95a3a35a8/substrate/client/service/src/client/client.rs#L488-L488 This renders warp sync useless for chains using this import queue. ## Fix The fix is to always import a block with state as best block, as we already do in the normal Aura Verifier. In a follow up we should also take another look into unifying the usage of the different import queues. fixes paritytech/project-mythical#256 --------- Co-authored-by: command-bot <> (cherry picked from commit 1dcff3d)
|
Successfully created backport PR for |
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…ue (#7050) ## Problem In the parachain template we use the [fully verifying import queue ](https://github.com/paritytech/polkadot-sdk/blob/3d9eddbeb262277c79f2b93b9efb5af95a3a35a8/cumulus/client/consensus/aura/src/equivocation_import_queue.rs#L224-L224) which does extra equivocation checks. However, when we import a warp synced block with state, we don't set a fork choice, leading to an incomplete block import pipeline and error here: https://github.com/paritytech/polkadot-sdk/blob/3d9eddbeb262277c79f2b93b9efb5af95a3a35a8/substrate/client/service/src/client/client.rs#L488-L488 This renders warp sync useless for chains using this import queue. ## Fix The fix is to always import a block with state as best block, as we already do in the normal Aura Verifier. In a follow up we should also take another look into unifying the usage of the different import queues. fixes paritytech/project-mythical#256 --------- Co-authored-by: command-bot <> (cherry picked from commit 1dcff3d)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2025
…ue (#7050) ## Problem In the parachain template we use the [fully verifying import queue ](https://github.com/paritytech/polkadot-sdk/blob/3d9eddbeb262277c79f2b93b9efb5af95a3a35a8/cumulus/client/consensus/aura/src/equivocation_import_queue.rs#L224-L224) which does extra equivocation checks. However, when we import a warp synced block with state, we don't set a fork choice, leading to an incomplete block import pipeline and error here: https://github.com/paritytech/polkadot-sdk/blob/3d9eddbeb262277c79f2b93b9efb5af95a3a35a8/substrate/client/service/src/client/client.rs#L488-L488 This renders warp sync useless for chains using this import queue. ## Fix The fix is to always import a block with state as best block, as we already do in the normal Aura Verifier. In a follow up we should also take another look into unifying the usage of the different import queues. fixes paritytech/project-mythical#256 --------- Co-authored-by: command-bot <> (cherry picked from commit 1dcff3d)
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jan 8, 2025
Backport #7050 into `stable2407` from skunert. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the parachain template we use the fully verifying import queue
which does extra equivocation checks.
However, when we import a warp synced block with state, we don't set a fork choice, leading to an incomplete block import pipeline and error here:
polkadot-sdk/substrate/client/service/src/client/client.rs
Line 488 in 3d9eddb
This renders warp sync useless for chains using this import queue.
Fix
The fix is to always import a block with state as best block, as we already do in the normal Aura Verifier.
In a follow up we should also take another look into unifying the usage of the different import queues.
fixes paritytech/project-mythical#256