Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding warning when using default substrateWeight in production #7046

Merged
merged 4 commits into from
Jan 7, 2025
Merged

adding warning when using default substrateWeight in production #7046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41486c7
added warning to std
Krayt78 Jan 5, 2025
f92ce4e
added not to cfg attribute
Krayt78 Jan 6, 2025
c135710
Update from ggwpez running command 'prdoc --audience runtime_dev --bu…
Jan 7, 2025
a15c03b
Update templates/parachain/pallets/template/src/weights.rs
Krayt78 Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions prdoc/pr_7046.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
title: adding warning when using default substrateWeight in production
doc:
- audience: Runtime Dev
description: |-
PR for #3581
Added a cfg to show a deprecated warning message when using std
crates: []
6 changes: 6 additions & 0 deletions templates/parachain/pallets/template/src/weights.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ pub trait WeightInfo {
}

/// Weights for pallet_template using the Substrate node and recommended hardware.
#[cfg_attr(
not(feature = "std"),
deprecated(
note = "SubstrateWeight is auto-generated and should not be used in production. Replace it with runtime benchmarked weights."
)
)]
pub struct SubstrateWeight<T>(PhantomData<T>);
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
/// Storage: Template Something (r:0 w:1)
Expand Down
Loading