adding warning when using default substrateWeight in production #7046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
@kianenigma this will probably trigger in some kitchensinks, not sure about the templates?
But since we dont have any production annotation, I think this should at least help a bit.
|
/cmd prdoc --audience runtime_dev --bump patch |
acatangiu
approved these changes
Jan 7, 2025
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Merged
via the queue into
paritytech:master
with commit Jan 7, 2025
645878a
195 of 201 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #3581
Added a cfg to show a deprecated warning message when using std