Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump some dependencies #5886

Merged
merged 13 commits into from
Oct 8, 2024
Merged

Bump some dependencies #5886

merged 13 commits into from
Oct 8, 2024
+156 −121

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 1, 2024

This bumps ethbloom, ethereum-types, primitive-types and rlp to their latest version.

Fixes: #5870

@bkchr
Bump some dependencies
4abb84d 
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to their latest version.

Fixes: #5870
@bkchr bkchr added the T17-primitives Changes to primitives that are not covered by any other label. label Oct 1, 2024
@bkchr bkchr requested review from skunert and ggwpez October 1, 2024 10:14
@bkchr bkchr requested a review from a team as a code owner October 1, 2024 10:14
@skunert
Copy link
Contributor

skunert commented Oct 1, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 1, 2024 •
edited
Loading

@skunert https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7475406 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-4b1db185-e40c-4a5c-a597-83e8fb2688a1 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 1, 2024

@skunert Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7475406 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7475406/artifacts/download.

@ggwpez ggwpez enabled auto-merge October 2, 2024 13:56
@pgherveou pgherveou mentioned this pull request Oct 8, 2024
Closed
ordian
ordian reviewed Oct 8, 2024
View reviewed changes
Cargo.lock Outdated
"hashbrown 0.12.3",
"impl-trait-for-tuples",
"lru 0.8.1",
"parity-util-mem-derive",
"parking_lot 0.12.3",
"primitive-types",
"primitive-types 0.12.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're still using parity-util-mem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed as in https://github.com/paritytech/polkadot-sdk/pull/5673/files

@bkchr bkchr disabled auto-merge October 8, 2024 20:54
@bkchr bkchr merged commit 5d82bdc into master Oct 8, 2024
210 of 221 checks passed
@bkchr bkchr deleted the bkchr-update-deps branch October 8, 2024 20:56
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 9, 2024
@bkchr @ggwpez
@shawntabrizi @seadanda @mordamax
Bump some dependencies (paritytech#5886)
92e6697 
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to
their latest version.

Fixes: paritytech#5870

---------

Co-authored-by: command-bot <>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this pull request Oct 9, 2024
@bkchr @ggwpez
@shawntabrizi @seadanda @mordamax
Bump some dependencies (paritytech#5886)
aecfebf 
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to
their latest version.

Fixes: paritytech#5870

---------

Co-authored-by: command-bot <>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
ordian
ordian reviewed Oct 9, 2024
View reviewed changes
substrate/client/consensus/babe/src/authorship.rs
@@ -108,7 +108,8 @@ pub(super) fn secondary_slot_author(
return None
}

let rand = U256::from((randomness, slot).using_encoded(sp_crypto_hashing::blake2_256));
let rand =
U256::from_little_endian(&(randomness, slot).using_encoded(sp_crypto_hashing::blake2_256));
Copy link
Member

@ordian ordian Oct 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't From::from based on from_big_endian?
see https://github.com/paritytech/parity-common/pull/859/files
can this create consensus problems with some nodes upgrading to this code?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/paritytech/polkadot-sdk/pull/5673/files#diff-01d2862c9d91433a2f2d36fbd35ac059786ce6daa7b09557cb0203f4a5031f8d

cc @pgherveou

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is causing the failures in some tests.

https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540617
https://grafana.teleport.parity.io/goto/P4omWXkHR?orgId=1

--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540639
https://grafana.teleport.parity.io/goto/8xYZZXkNg?orgId=1

--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540550
https://grafana.teleport.parity.io/goto/WvoIZXkNR?orgId=1

--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540540
https://grafana.teleport.parity.io/goto/0uUHWuzHR?orgId=1

--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540189
https://grafana.teleport.parity.io/goto/6PeOZXkHR?orgId=1

--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7540084
https://grafana.teleport.parity.io/goto/jWV5ZXzNR?orgId=1

--
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7539899
https://grafana.teleport.parity.io/goto/yjEpWukHR?orgId=1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5994

@ordian ordian mentioned this pull request Oct 9, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2024
@ordian @bkchr
Fix u256 conversion in BABE (#5994)
292bfac 
#5886 (comment)

---------

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepoviola pepoviola pepoviola left review comments

@ordian ordian ordian left review comments

@pgherveou pgherveou pgherveou approved these changes

@skunert skunert skunert approved these changes

@ggwpez ggwpez ggwpez approved these changes

@seadanda seadanda seadanda approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
T17-primitives Changes to primitives that are not covered by any other label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest release contains clashing subdependencies
9 participants
@bkchr @skunert @pepoviola @pgherveou @ordian @ggwpez @seadanda @lexnv @shawntabrizi