Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release contains clashing subdependencies #5870

Closed
2 tasks done
louismerlin opened this issue Sep 30, 2024 · 3 comments · Fixed by #5886
Closed
2 tasks done

Latest release contains clashing subdependencies #5870

louismerlin opened this issue Sep 30, 2024 · 3 comments · Fixed by #5886
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@louismerlin
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

When importing the latest released version of kitchensink-runtime as a dependency, Cargo finds clashing subdependencies: primitive-types versions 0.12.2 and 0.13.1 are incompatible, and both are present in the dependency tree.

See the error logs for more details.

error.log

Steps to reproduce

Create a new Rust project with Cargo:

cargo new kitchensink-import-test

Append this line to the Cargo.toml:

kitchensink-runtime = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-stable2409", features = ["std"] }

Try to build the project:

cargo +nightly build

You should get the same output as I provided.

@louismerlin louismerlin added I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known. labels Sep 30, 2024
@bkchr
Copy link
Member

bkchr commented Sep 30, 2024

cargo update -p ethabi-decode --precise 1.0.0 this fixes your issue. We need to upgrade here in the repo so that this doesn't happen anymore.

bkchr added a commit that referenced this issue Oct 1, 2024
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to their latest version.

Fixes: #5870
@ggwpez
Copy link
Member

ggwpez commented Oct 2, 2024

The offending ethabi-decode version should also be yanked now: Snowfork/ethabi-decode#12
I think we dont need to backport a version pin to stable2409 since cargo should not pick up the yanked version anymore.

Is it fixed for you?

@louismerlin
Copy link
Contributor Author

Everything works on my end, thanks a lot for the support!

bkchr added a commit that referenced this issue Oct 8, 2024
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to
their latest version.

Fixes: #5870

---------

Co-authored-by: command-bot <>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 9, 2024
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to
their latest version.

Fixes: paritytech#5870

---------

Co-authored-by: command-bot <>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 9, 2024
This bumps `ethbloom`, `ethereum-types`, `primitive-types` and `rlp` to
their latest version.

Fixes: paritytech#5870

---------

Co-authored-by: command-bot <>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Dónal Murray <donal.murray@parity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants