Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx-pool: replace error-chain with vanilla Error impl #114

Merged
merged 6 commits into from
Mar 1, 2019
Merged

tx-pool: replace error-chain with vanilla Error impl #114

merged 6 commits into from
Mar 1, 2019

Conversation

ascjones
Copy link
Contributor

@ascjones ascjones commented Mar 1, 2019

Because of Error::cause deprecation in 1.33.

Re: openethereum/parity-ethereum#10302, paritytech/substrate#1547

@ascjones ascjones requested a review from tomusdrw March 1, 2019 14:19
bkchr
bkchr approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nitpick.

@bkchr @ascjones
Update transaction-pool/src/error.rs
0e1bdb6 
Co-Authored-By: ascjones <ascjones@gmail.com>
@ascjones ascjones merged commit a31b51c into master Mar 1, 2019
@ascjones ascjones deleted the aj-tx-error-chain branch March 1, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ascjones @tomusdrw @bkchr