-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Replace error-chain
#10302
Comments
In #10510 I manually implemented Here's one of the regexes I used for the variants inside
|
nice work, yeah looks good to me. could make sense to write a macro for the impl error::Error for Error {
fn source(&self) -> Option<&(error::Error + 'static)> {
match self {
Error::Io(e) => Some(e),
// more patterns
_ => None,
}
}
} |
At first I converted to using err-derive which has essentially just copied However I decided to user the more general and popular So we could just copy that macro from there or consider adding a dependency to it. In the meantime I figured it's not that bad to implement |
Ok, I see. Let's go with a manual implementation for now and see how much |
error-chain
is not maintained anymore and depends on Error::cause which will be deprecated in Rust 1.33.I don't know what the best solution to this but what I can think of:
failure
The text was updated successfully, but these errors were encountered: