-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely, lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space
util/network/src/error.rs
Outdated
/// Rlp decoder error. | ||
Rlp(rlp::DecoderError), | ||
/// Error concerning the network address parsing subsystem. | ||
#[display(fmt ="Failed to parse network address")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Failed to parse network address")] | |
#[display(fmt = "Failed to parse network address")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Failed to parse network address")] | ||
AddressParse, | ||
/// Error concerning the network address resolution subsystem. | ||
#[display(fmt ="Failed to resolve network address {}", _0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Failed to resolve network address {}", _0)] | |
#[display(fmt = "Failed to resolve network address {}", _0)] |
util/network/src/error.rs
Outdated
#[display(fmt ="Failed to resolve network address {}", _0)] | ||
AddressResolve(AddressResolveError), | ||
/// Authentication failure | ||
#[display(fmt ="Authentication failure")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Authentication failure")] | |
#[display(fmt = "Authentication failure")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Authentication failure")] | ||
Auth, | ||
/// Unrecognised protocol | ||
#[display(fmt ="Bad protocol")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Bad protocol")] | |
#[display(fmt = "Bad protocol")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Bad protocol")] | ||
BadProtocol, | ||
/// Expired message | ||
#[display(fmt ="Expired message")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Expired message")] | |
#[display(fmt = "Expired message")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Peer disconnected: {}", _0)] | ||
Disconnect(DisconnectReason), | ||
/// Invalid node id | ||
#[display(fmt ="Invalid node id")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Invalid node id")] | |
#[display(fmt = "Invalid node id")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Invalid node id")] | ||
InvalidNodeId, | ||
/// Packet size is over the protocol limit | ||
#[display(fmt ="Packet is too large")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Packet is too large")] | |
#[display(fmt = "Packet is too large")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Packet is too large")] | ||
OversizedPacket, | ||
/// Reached system resource limits for this process | ||
#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")] | |
#[display(fmt = "Too many open files in this process. Check your resource limits and restart parity")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Too many open files in this process. Check your resource limits and restart parity")] | ||
ProcessTooManyFiles, | ||
/// Reached system wide resource limits | ||
#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")] | |
#[display(fmt = "Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")] |
util/network/src/error.rs
Outdated
#[display(fmt ="Too many open files on system. Consider closing some processes/release some file handlers or increas the system-wide resource limits and restart parity.")] | ||
SystemTooManyFiles, | ||
/// An unknown IO error occurred. | ||
#[display(fmt ="Unexpected IO error: {}", _0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[display(fmt ="Unexpected IO error: {}", _0)] | |
#[display(fmt = "Unexpected IO error: {}", _0)] |
@dvdplm just killed all those |
…me-parent * master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)
* master: updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731) Stop breaking out of loop if a non-canonical hash is found (#10729) Refactor Clique stepping (#10691) Use RUSTFLAGS to set the optimization level (#10719) SecretStore: non-blocking wait of session completion (#10303) removed secret_store folder (#10722) SecretStore: expose restore_key_public in HTTP API (#10241) Revert "enable lto for release builds (#10717)" (#10721) enable lto for release builds (#10717) Merge `Notifier` and `TransactionsPoolNotifier` (#10591)
* master: Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731) Stop breaking out of loop if a non-canonical hash is found (#10729) Refactor Clique stepping (#10691) Use RUSTFLAGS to set the optimization level (#10719) SecretStore: non-blocking wait of session completion (#10303) removed secret_store folder (#10722) SecretStore: expose restore_key_public in HTTP API (#10241) Revert "enable lto for release builds (#10717)" (#10721) enable lto for release builds (#10717) Merge `Notifier` and `TransactionsPoolNotifier` (#10591)
…-even * master: [devp2p] Update to 2018 edition (#10716) Add a way to signal shutdown to snapshotting threads (#10744) Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)
…p/chore/aura-log-validator-set-in-epoch-manager * dp/chore/aura-warn-when-validators-is-1-or-even: [devp2p] Update to 2018 edition (#10716) Add a way to signal shutdown to snapshotting threads (#10744) Enable aesni (#10756) remove support of old SS db formats (#10757) [devp2p] Don't use `rust-crypto` (#10714) updater: fix static id hashes initialization (#10755) Use fewer threads for snapshotting (#10752) Die error_chain, die (#10747) Fix deprectation warnings on nightly (#10746) fix docker tags for publishing (#10741) Update ethcore/src/engines/validator_set/simple_list.rs DevP2p: Get node IP address and udp port from Socket, if not included in PING packet (#10705) ethcore: enable ECIP-1054 for classic (#10731)
Resolves #10302.