-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pallet::without_storage_info from bridge GRANDPA pallet #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
the
A-chores
Something that has to be done, as part of regular maintenance
label
Jun 27, 2022
acatangiu
approved these changes
Oct 7, 2022
serban300
reviewed
Oct 7, 2022
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
…om/paritytech/parity-bridges-common into max-encoded-len-for-grandpa-pallet
serban300
approved these changes
Oct 10, 2022
bkontur
reviewed
Oct 10, 2022
bkontur
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
jiguantong
added a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Nov 17, 2022
hackfisher
pushed a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Nov 21, 2022
* update substrate dep master > v0.9.30 * Companion for paritytech/parity-bridges-common#1589 * Companion for paritytech/parity-bridges-common#1593 * Companion for paritytech/parity-bridges-common#1478 * Companion for paritytech/parity-bridges-common#1596 * Companion for paritytech/parity-bridges-common#1600 * Companion for paritytech/parity-bridges-common#1603 * Companion for paritytech/parity-bridges-common#1604 * Companion for paritytech/parity-bridges-common#1597 part.1 * Companion for paritytech/parity-bridges-common#1597 part.2 update weights * Companion for paritytech/parity-bridges-common#1597 part.3 * Companion for paritytech/parity-bridges-common#1597 part.4 fix compile * clear unused imports * Companion for paritytech/parity-bridges-common#1613 part.1 undone * fix tests
jiguantong
added a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Nov 21, 2022
* update substrate dep master > v0.9.30 * Companion for paritytech/parity-bridges-common#1589 * Companion for paritytech/parity-bridges-common#1593 * Companion for paritytech/parity-bridges-common#1478 * Companion for paritytech/parity-bridges-common#1596 * Companion for paritytech/parity-bridges-common#1600 * Companion for paritytech/parity-bridges-common#1603 * Companion for paritytech/parity-bridges-common#1604 * Companion for paritytech/parity-bridges-common#1597 part.1 * Companion for paritytech/parity-bridges-common#1597 part.2 update weights * Companion for paritytech/parity-bridges-common#1597 part.3 * Companion for paritytech/parity-bridges-common#1597 part.4 fix compile * clear unused imports * Companion for paritytech/parity-bridges-common#1613 part.1 undone * fix tests
boundless-forest
added a commit
to darwinia-network/darwinia-messages-substrate
that referenced
this pull request
Jan 4, 2023
* Prepare polkadot v0.9.30 for darwinia-2.0 (#226) * update substrate dep master > v0.9.30 * Companion for paritytech/parity-bridges-common#1589 * Companion for paritytech/parity-bridges-common#1593 * Companion for paritytech/parity-bridges-common#1478 * Companion for paritytech/parity-bridges-common#1596 * Companion for paritytech/parity-bridges-common#1600 * Companion for paritytech/parity-bridges-common#1603 * Companion for paritytech/parity-bridges-common#1604 * Companion for paritytech/parity-bridges-common#1597 part.1 * Companion for paritytech/parity-bridges-common#1597 part.2 update weights * Companion for paritytech/parity-bridges-common#1597 part.3 * Companion for paritytech/parity-bridges-common#1597 part.4 fix compile * clear unused imports * Companion for paritytech/parity-bridges-common#1613 part.1 undone * fix tests * 0930 > master * try fix CI * fix CI * Use `H160` as `AccountId` (#230) * Use H160 in darwinia-core * H256 > H160 * update moonbeam account * Fix tests * remove debug println * Fix review * Fix review * Compatible `derive_account_id` (#234) * new derive_account_id * adjust * add test * Keep compatible of the derive way * Fix test * Update converter * Self review Co-authored-by: Aki Wu <aki.wu@itering.com> * update cargo * master -> polkadot-v0.9.30 Co-authored-by: bear <boundless.forest@outlook.com> Co-authored-by: Aki Wu <aki.wu@itering.com>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…ytech#1478) * remove pallet::without_storage_info from bridge GRANDPA pallet * StoredBridgedHeader * spelling * fix benchmarks * MAX_BRIDGED_AUTHORITIES: 256 -> 2048 * Update modules/grandpa/src/storage_types.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> * Update modules/grandpa/src/storage_types.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> * moved max authorities + header size to chain primitives * removed unused code * new -> try_new * fix benchmarks compilation Co-authored-by: Adrian Catangiu <adrian@parity.io>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…ytech#1478) * remove pallet::without_storage_info from bridge GRANDPA pallet * StoredBridgedHeader * spelling * fix benchmarks * MAX_BRIDGED_AUTHORITIES: 256 -> 2048 * Update modules/grandpa/src/storage_types.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> * Update modules/grandpa/src/storage_types.rs Co-authored-by: Adrian Catangiu <adrian@parity.io> * moved max authorities + header size to chain primitives * removed unused code * new -> try_new * fix benchmarks compilation Co-authored-by: Adrian Catangiu <adrian@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-chores
Something that has to be done, as part of regular maintenance
PR-audit-needed
A PR has to be audited before going live.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1433
it'll stay draft until the similar issue with system pallet is resolved (see explanation below)
I've tried to implement that, but looks like there are some more general problems that need to be solved first. Right now the main issue is that the generic header is not implementing the
MaxEncodedLen
. And it is what we're storing in the runtime storage.The similar case is with the system pallet, which is storing recent headers - so let's see how frame guys will solve it there. I assume that we'll have some upper bound on header size? Then we'll also need to do similar thing here.I've been wrong obviously - system pallet is only storing block hashes. But there's still problem with paras pallet (https://github.com/paritytech/polkadot/blob/master/runtime/parachains/src/paras/mod.rs), which doesn't generate storage info too.With parachains finality pallet it is even more complex. because we deal with multiple parachains there. So we shall use
max(max-of-parachain-1, max-of-parachain-2, ...)
.The fix for messages pallet looks easier - we already are limiting the message size. The only thing is that it is missing from the pallet configuration (it is configured through the message verifier trait).
UPD: I doubt that the parachains pallet will be fixed, because it is deployed at relay chain