This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Use H160 as AccountId
#230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiguantong
requested review from
fewensa and
AurevoirXavier
and removed request for
fewensa
Closed
|
Sorry, I'll review this deeper tomorrow~ |
|
Left another feedback, other changes LGTM. |
boundless-forest
approved these changes
Nov 30, 2022
4 tasks
jiguantong
added a commit
that referenced
this pull request
Jan 4, 2023
boundless-forest
added a commit
that referenced
this pull request
Jan 4, 2023
* Prepare polkadot v0.9.30 for darwinia-2.0 (#226) * update substrate dep master > v0.9.30 * Companion for paritytech/parity-bridges-common#1589 * Companion for paritytech/parity-bridges-common#1593 * Companion for paritytech/parity-bridges-common#1478 * Companion for paritytech/parity-bridges-common#1596 * Companion for paritytech/parity-bridges-common#1600 * Companion for paritytech/parity-bridges-common#1603 * Companion for paritytech/parity-bridges-common#1604 * Companion for paritytech/parity-bridges-common#1597 part.1 * Companion for paritytech/parity-bridges-common#1597 part.2 update weights * Companion for paritytech/parity-bridges-common#1597 part.3 * Companion for paritytech/parity-bridges-common#1597 part.4 fix compile * clear unused imports * Companion for paritytech/parity-bridges-common#1613 part.1 undone * fix tests * 0930 > master * try fix CI * fix CI * Use `H160` as `AccountId` (#230) * Use H160 in darwinia-core * H256 > H160 * update moonbeam account * Fix tests * remove debug println * Fix review * Fix review * Compatible `derive_account_id` (#234) * new derive_account_id * adjust * add test * Keep compatible of the derive way * Fix test * Update converter * Self review Co-authored-by: Aki Wu <aki.wu@itering.com> * update cargo * master -> polkadot-v0.9.30 Co-authored-by: bear <boundless.forest@outlook.com> Co-authored-by: Aki Wu <aki.wu@itering.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
H160asAccountId#229