Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add missing workspace members #3056

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Add missing workspace members #3056

merged 3 commits into from
Aug 24, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Aug 24, 2023

(preparation for the monorepo)

Turns out the bridge crates that were omitted in #2843 actually do need to be added.
Check script now reports all green:

🔎 Checking folder .
📜 Found workspace manifest
📜 Found 88 crates in the workspace
✅ All 471 dependency links are correct

@ggwpez
Add dependencies
24b60d8 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Add missing workspace members
10f0cef 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added B0-silent Changes should not be mentioned in any release notes A3-in_progress Pull request is in progress. No review needed at this stage. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 24, 2023
@ggwpez ggwpez self-assigned this Aug 24, 2023
@ggwpez
Fix more
62f1e92 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review August 24, 2023 10:56
@ggwpez ggwpez added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 24, 2023
@paritytech-ci paritytech-ci requested a review from a team August 24, 2023 10:56
@ggwpez
Copy link
Member Author

ggwpez commented Aug 24, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 0424eca into master Aug 24, 2023
9 of 10 checks passed
@paritytech-processbot paritytech-processbot bot deleted the oty-add-bridge-crates branch August 24, 2023 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@serban300 serban300 serban300 approved these changes

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggwpez @bkchr @serban300