Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add missing workspace members #2843

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Add missing workspace members #2843

merged 3 commits into from
Jul 31, 2023

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Jul 7, 2023 •
edited
Loading

Checked with python check-deps.py cumulus/ script.

The following crates are still missing and not added since they are in a subtree:

🔎 Checking folder .
📜 Found workspace manifest
💥 Workspace members don't match manifest paths: 68 vs 84
❌ bp-bridge-hub-cumulus in bridges/primitives/chain-bridge-hub-cumulus
❌ bp-bridge-hub-kusama in bridges/primitives/chain-bridge-hub-kusama
❌ bp-bridge-hub-polkadot in bridges/primitives/chain-bridge-hub-polkadot
❌ bp-bridge-hub-rococo in bridges/primitives/chain-bridge-hub-rococo
❌ bp-bridge-hub-wococo in bridges/primitives/chain-bridge-hub-wococo
❌ bp-kusama in bridges/primitives/chain-kusama
❌ bp-polkadot in bridges/primitives/chain-polkadot
❌ bp-rococo in bridges/primitives/chain-rococo
❌ bp-wococo in bridges/primitives/chain-wococo
❌ bp-header-chain in bridges/primitives/header-chain
❌ bp-messages in bridges/primitives/messages
❌ bp-parachains in bridges/primitives/parachains
❌ bp-polkadot-core in bridges/primitives/polkadot-core
❌ bp-relayers in bridges/primitives/relayers
❌ bp-runtime in bridges/primitives/runtime
❌ bp-test-utils in bridges/primitives/test-utils

@ggwpez
Step 1: Sort workspace members
ed0d813 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Step 2: Add missing workspace members
a4a517b 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes labels Jul 7, 2023
@ggwpez ggwpez requested a review from bkchr July 25, 2023 17:02
@bkchr bkchr merged commit 5ce8e30 into master Jul 31, 2023
5 checks passed
@bkchr bkchr deleted the oty-fix-workspace branch July 31, 2023 08:31
@ggwpez ggwpez self-assigned this Aug 14, 2023
@ggwpez ggwpez mentioned this pull request Aug 24, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gilescope gilescope gilescope approved these changes

@bkchr bkchr bkchr approved these changes

Assignees

@ggwpez ggwpez

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggwpez @gilescope @bkchr