Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

benchmark script: remove file name for --output argument #2998

Merged
merged 1 commit into from
Aug 21, 2023
Merged

benchmark script: remove file name for --output argument #2998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/benchmarks-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ fi

for pallet in ${pallets[@]}
do
output_file="${pallet//::/_}"
output_dir=""
extra_args=""
# a little hack for pallet_xcm_benchmarks - we want to force custom implementation for XcmWeightInfo
if [[ "$pallet" == "pallet_xcm_benchmarks::generic" ]] || [[ "$pallet" == "pallet_xcm_benchmarks::fungible" ]]; then
output_file="xcm/$output_file"
output_dir="xcm/"
extra_args="--template=./templates/xcm-bench-template.hbs"
fi
$artifactsDir/polkadot-parachain benchmark pallet \
Expand All @@ -48,5 +48,5 @@ do
--repeat=$repeat \
--json \
--header=./file_header.txt \
--output="${benchmarkOutput}/${output_file}.rs" >> $artifactsDir/${pallet}_benchmark.json
--output="${benchmarkOutput}/${output_dir}" >> $artifactsDir/${pallet}_benchmark.json
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the artifacts/json file names still can collide.
I will address it later if we merge this - paritytech/substrate#14757

done